From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] Added package xcalib Date: Tue, 15 Nov 2016 14:35:43 -0500 Message-ID: <20161115193543.GB420@jasmine> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6jWJ-00015r-FR for guix-devel@gnu.org; Tue, 15 Nov 2016 14:35:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6jWD-0004lU-W2 for guix-devel@gnu.org; Tue, 15 Nov 2016 14:35:51 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:38613) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c6jWD-0004lO-Ri for guix-devel@gnu.org; Tue, 15 Nov 2016 14:35:45 -0500 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Petter Cc: guix-devel@gnu.org On Mon, Nov 14, 2016 at 05:05:55PM +0100, Petter wrote: > Hi, > > I just made a recipe for xcalib, with help from iyzsong. This is the first > time I've created one so please be extra alert while reviewing, and don't > hesitate to inform me of mistakes. Thanks Petter and iyzsong! I think the package should go in the (gnu packages xdisorg) module instead of its own module. > From 00ca66ec205baf52dc340faa61fd8ac38122e273 Mon Sep 17 00:00:00 2001 > From: Petter > Date: Mon, 14 Nov 2016 16:56:33 +0100 > Subject: [PATCH] Added package xcalib The commit title should be "gnu: Add xcalib.". Also, please add a "changelog" line describing the code changes. In this case, it should be: * gnu/packages/xdisorg (xcalib): New variable. This is the GNU convention, and we mention it in the manual, section 8.5 Submitting Patches [0]. Please refer to earlier Git commits or ask for help on IRC if you are unsure about it. [0] https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html > +(define-public xcalib > + (package > + (name "xcalib") > + (version "0.8") > + (source (origin > + (method url-fetch) > + (uri (string-append "http://downloads.sourceforge.net/xcalib/" > + "xcalib-source-" version ".tar.gz")) We have a SourceForge "mirror" URL that should be used. Grep for 'mirror://sourceforge' in gnu/packages for some examples of how to use it. > + (arguments > + '(#:make-flags '("CC=gcc") > + #:phases (modify-phases %standard-phases > + (delete 'configure) > + (delete 'check) Please add a comment explaining why we skip the tests. If there is no test suite, just use "No test suite". Also, we prefer to skip tests by setting #:tests? #f instead of deleting the check phase. > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin"))) > + (mkdir-p bin) > + (install-file "xcalib" bin))))))) Okay. Please check if there is any documentation that could also be installed. You can add a build phase before 'install that just fails: (lambda _ #f), build with --keep-failed, and then look in the build directory for man pages, READMEs, Info pages, etc. > + (license gpl2))) Please double-check if the source files contain the "or later" text in the license headers. If so, it's gpl2+.