From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: [PATCH 1/4] gnu: Separate util-linux into three packages. Date: Fri, 11 Nov 2016 17:03:41 +0100 Message-ID: <20161111160341.GA1935@jocasta.intra> References: <1478812461-18483-1-git-send-email-jmd@gnu.org> <5825D914.6000508@crazy-compilers.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zhXaljGHf11kAtnf" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47860) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c5EIy-000593-TF for guix-devel@gnu.org; Fri, 11 Nov 2016 11:03:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c5EIy-0007fx-15 for guix-devel@gnu.org; Fri, 11 Nov 2016 11:03:52 -0500 Content-Disposition: inline In-Reply-To: <5825D914.6000508@crazy-compilers.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Hartmut Goebel Cc: guix-devel@gnu.org, John Darrington --zhXaljGHf11kAtnf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 11, 2016 at 03:43:32PM +0100, Hartmut Goebel wrote: Am 10.11.2016 um 22:14 schrieb John Darrington: > +(define-public util-linux/base > (package > - (name "util-linux") > + (name "util-linux-base") =20 I'm in favour of naming the variable as the package. This eases using = them. I tried that. It seems that there is a precident to use /variant for the = variable. However / is not permitted in the name =20 > +(define-public util-linux > + (package > + (inherit util-linux/base) > + (name "util-linux") > + (source (origin (inherit (package-source util-linux/base)))) =20 I'm curious: Why do you need to inherit the package-source here? =20 Well I don't actually *need* to. I could have copied it. But I thought th= at having 3 copies would make maintenance difficult---somebody might update on= e, but forget the other two. =20 --=20 Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --zhXaljGHf11kAtnf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlgl690ACgkQimdxnC3oJ7PDcACdGoEMS6VaE8gDjm6Ud4BdZ5u8 RhQAn2BTau6ihRXT24FuE143na/j79Fn =YC5N -----END PGP SIGNATURE----- --zhXaljGHf11kAtnf--