unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/3] gnu: Add python-pypdf2.
Date: Tue, 8 Nov 2016 18:55:24 -0500	[thread overview]
Message-ID: <20161108235524.GA25046@jasmine> (raw)
In-Reply-To: <1478641022-30723-1-git-send-email-h.goebel@crazy-compilers.com>

On Tue, Nov 08, 2016 at 10:37:00PM +0100, Hartmut Goebel wrote:
> * gnu/packages/pdf.scm(python-pypdf2, python2-pypdf2): New variables.

> +    (arguments
> +      '(#:tests? #f))  ; no tests

Are these files not relevant?

https://github.com/mstamy2/PyPDF2/tree/master/Tests

> +    (home-page "http://mstamy2.github.com/PyPDF2")
> +    (synopsis "Pure-Python PDF toolkit")

I would replace the hyphen in "Pure-Python" with a space.

> +    (description "A Pure-Python library built as a PDF toolkit.  It is capable

Same here.

> +of:
> +
> +@itemize
> +@item extracting document information (title, author, …)
> +@item splitting documents page by page
> +@item merging documents page by page
> +@item cropping pages
> +@item merging multiple pages into a single page
> +@item encrypting and decrypting PDF files
> +@item and more!
> +@end itemize

We have to use enumerate instead of itemize due to a limitation in
Guile's texinfo -> HTML converter. This is fixed in Guile, but not in
the version that we use currently, IIUC:

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=21772
https://lists.gnu.org/archive/html/guile-commits/2016-06/msg00341.html

$ git describe --contains bd65845497110b179456d4bfdf26854791f0a822
v2.1.4~95

  parent reply	other threads:[~2016-11-08 23:55 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-08 21:37 [PATCH 1/3] gnu: Add python-pypdf2 Hartmut Goebel
2016-11-08 21:37 ` [PATCH 2/3] gnu: Add python-pypdf Hartmut Goebel
2016-11-08 23:57   ` Leo Famulari
2016-11-09 22:04     ` Hartmut Goebel
2016-11-09  7:19   ` Efraim Flashner
2016-11-09 22:10     ` Hartmut Goebel
2016-11-08 21:37 ` [PATCH 3/3] gnu: Add pdfposter Hartmut Goebel
2016-11-09  0:02   ` Leo Famulari
2016-11-09 22:19     ` Hartmut Goebel
2016-11-08 23:55 ` Leo Famulari [this message]
2016-11-09 21:59   ` [PATCH 1/3] gnu: Add python-pypdf2 Hartmut Goebel
2016-11-09 22:39 ` [Patch v2 " Hartmut Goebel
2016-11-09 22:39   ` [Patch v2 2/3] gnu: Add python-pypdf Hartmut Goebel
2016-11-10 10:47     ` Ludovic Courtès
2016-11-09 22:39   ` [Patch v2 3/3] gnu: Add pdfposter Hartmut Goebel
2016-11-10  7:51     ` Efraim Flashner
2016-11-10 10:48       ` Ludovic Courtès
2016-11-10 13:28         ` Hartmut Goebel
2016-11-10 10:46   ` [Patch v2 1/3] gnu: Add python-pypdf2 Ludovic Courtès
2016-11-10 10:58     ` Hartmut Goebel
2016-11-10 12:35       ` Ludovic Courtès
2016-11-10 13:10         ` Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161108235524.GA25046@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=h.goebel@crazy-compilers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).