From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: Re: [PATCH 4/5] install: Extract procedure: install-grub-config. Date: Sun, 6 Nov 2016 22:00:01 +0100 Message-ID: <20161106220001.1ca62b07@scratchpost.org> References: <87d1ihscmr.fsf@gnu.org> <20161102054815.11253-1-cmmarusich@gmail.com> <20161102054815.11253-5-cmmarusich@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:53449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3UXy-0005QW-2t for guix-devel@gnu.org; Sun, 06 Nov 2016 16:00:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3UXv-0000tC-2m for guix-devel@gnu.org; Sun, 06 Nov 2016 16:00:10 -0500 Received: from dd1012.kasserver.com ([85.13.128.8]:34616) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c3UXu-0000rK-Tw for guix-devel@gnu.org; Sun, 06 Nov 2016 16:00:07 -0500 In-Reply-To: <20161102054815.11253-5-cmmarusich@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: cmmarusich@gmail.com Cc: guix-devel@gnu.org Thanks for this! > -(define* (install-grub grub.cfg device mount-point) > +(define (install-grub grub.cfg device mount-point) > "Install GRUB with GRUB.CFG on DEVICE, which is assumed to be mounted on > MOUNT-POINT. > > Note that the caller must make sure that GRUB.CFG is registered as a GC root > so that the fonts, background images, etc. referred to by GRUB.CFG are not > GC'd." > + (install-grub-config grub.cfg mount-point) > + (unless (zero? (system* "grub-install" "--no-floppy" ^^^ since you have touched it, maybe you know: How does it know which package's (which directory's) grub-install to invoke here?