From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: w3m: Switch to Debian's actively maintained fork of w3m. Date: Fri, 4 Nov 2016 19:54:13 -0400 Message-ID: <20161104235413.GA22735@jasmine> References: <87mvhgw4w0.fsf@openmailbox.org> <20161103221718.123dc755@centurylink.net> <20161104040309.GA5474@jasmine> <8760o31il3.fsf@gnu.org> <87d1ibwb3s.fsf@openmailbox.org> <20161104154856.GD14769@jasmine> <874m3nqipt.fsf@openmailbox.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3V7upXqbjpZ4EhLz" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c2oJP-0007Cg-8B for guix-devel@gnu.org; Fri, 04 Nov 2016 19:54:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c2oJL-0000fZ-PB for guix-devel@gnu.org; Fri, 04 Nov 2016 19:54:19 -0400 Content-Disposition: inline In-Reply-To: <874m3nqipt.fsf@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Kei Kebreau Cc: guix-devel@gnu.org --3V7upXqbjpZ4EhLz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 04, 2016 at 01:05:02PM -0400, Kei Kebreau wrote: > From 1eede14194c83b70725b6de062b9d3e0acce6340 Mon Sep 17 00:00:00 2001 > From: Kei Kebreau > Date: Fri, 4 Nov 2016 12:43:28 -0400 > Subject: [PATCH] gnu: w3m: Switch to Debian's actively maintained fork of= w3m. >=20 > Fixes some security issues seen here: > >=20 > * gnu/packages/w3m.scm (w3m): Switch it. > [source]: Use Debian's git tree. Remove obsolete patches. > [arguments]: Remove unnecessary modification of %standard-phases. > * gnu/packages/patches/w3m-disable-sslv2-and-sslv3.patch, > gnu/packages/patches/w3m-disable-weak-ciphers.patch, > gnu/packages/patches/w3m-force-ssl_verify_server-on.patch, > gnu/packages/patches/w3m-libgc.patch: Delete files. > * gnu/local.mk (dist_patch_DATA): Remove them. > + (let ((commit "5cf75248f5833db00d53a33c30a525bb40f5512b") > + (revision "1")) ; Guix package revision > + (package > + (name "w3m") > + (version (string-append "0.5.3-" revision "." (string-take commit = 7))) > + (source (origin > + (method git-fetch) > + ;; Debian's fork of w3m is the only one that is still > + ;; maintained. > + (uri (git-reference > + (url "https://anonscm.debian.org/cgit/collab-maint= /w3m.git") > + (commit commit))) We can just use the Git tag as the version and the commit, like in this stale package: https://github.com/lfam/pkgs/blob/master/leo/packages/w3m-debian.scm I think that's simpler. Looks good with this change :) --3V7upXqbjpZ4EhLz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIbBAEBCAAGBQJYHR+lAAoJECZG+jC6yn8InFgP+JOpV6p07Gf9fk6W5AB9Sb1S tN8w15pwX8tnVgw9pyrSM6hHOOkZi/woKJct2P08RwM709S/+QXfbCwx86lgEgo+ 6renvm/d+1gOyTR6MH0TowWLiSsc5Tm0qtzD3oeHvlsnDF4GGGCrqxFh3UiDqy+m 4T7Ai5o9pkGDGEWU8DCKub6Xm6zFw5sEUy8beNekEN6DhO0hWmDVLxhTWbnXpZv3 NWJsgSXa2Jhw9cpHfCPo0TiwemynCFidwClTBKmMhE/s91S3vyZTikmhdX5zrdBT YOe9bYqDiAidfshDPmGdzEQRnr3RYSGrnMx9XDLjh6fwgbL9jgZg3FuoeSks8jkP jwvIrx+CwZNemotSj6tXDfpB4j0pEUvrciCU45RJH4z5uOvHMWbceUd6MUNTEC/C q7Bz66YyawHzREjy9eBYUoSrcaCEHJT/4dohQ5LMdx5jqlYOxnSWaOer2vFZX3zb FASmTB4Lig1WCCv0nbEGsIyyVr6HhbArj4coVFOjEW5i49FBE8bk5Ma8jCDed1C8 Dya9qdW7DOql6cjwdXz56euXX9RBR6K+RFICQlN1AJzjBJkbDmaX/54plkbio+cf jhrRO1u6CjkiY9+oN+QGk6uyAGj6uT353Fx7hEXa7j+dEF6Hqc9ScIRm/dNhcyoI l0tEqqq7t6FK/KkfWLY= =9icW -----END PGP SIGNATURE----- --3V7upXqbjpZ4EhLz--