* [PATCH] gnu: Update sunxi-tools to 1.4
@ 2016-10-26 21:21 Danny Milosavljevic
2016-10-27 5:22 ` John Darrington
2016-10-27 6:27 ` Efraim Flashner
0 siblings, 2 replies; 6+ messages in thread
From: Danny Milosavljevic @ 2016-10-26 21:21 UTC (permalink / raw
To: guix-devel
---
gnu/packages/admin.scm | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index d9b08ef..856d946 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -1859,14 +1859,14 @@ Kerberos and Heimdal and FAST is supported with recent MIT Kerberos.")
(define-public sunxi-tools
(package
(name "sunxi-tools")
- (version "1.3")
+ (version "1.4")
(source
(origin
(method url-fetch)
(uri (string-append "https://github.com/linux-sunxi/"
"sunxi-tools/archive/v" version ".tar.gz"))
(sha256
- (base32 "1iazm28gws1i8sls3gxwc5p108n56ags287zmh1rpvkn2k1az81a"))
+ (base32 "1hx72cx4wj9w4c6niq0b6l3c5aj259g392z6y3a5f7fnybanq3pq"))
(modules '((guix build utils)))
(snippet
;; Remove binaries contained in the tarball which are only for the
@@ -1882,8 +1882,9 @@ Kerberos and Heimdal and FAST is supported with recent MIT Kerberos.")
`(#:tests? #f ; no tests exist
#:make-flags (list (string-append "PREFIX="
(assoc-ref %outputs "out"))
- "TARGET_TOOLS=sunxi-pio sunxi-meminfo"
- "CROSS_COMPILE=")
+ "TARGET_TOOLS=sunxi-pio sunxi-meminfo sunxi-script_extractor"
+ "CROSS_COMPILE="
+ "CC=gcc")
#:phases
(modify-phases %standard-phases
(add-after 'unpack 'fix-Makefile
@@ -1892,7 +1893,7 @@ Kerberos and Heimdal and FAST is supported with recent MIT Kerberos.")
;; Upstream adds Makefile and config.h as dependencies
;; of all their tools which means $^ would pass them to gcc.
;; gcc won't know what to do with a Makefile.
- (("-o [$][@] [$]\\^") "-o $@ meminfo.c"))
+ (("-o [$][@] [$]\\^") "-o $@ $<"))
#t))
(delete 'configure))))
(home-page "https://github.com/linux-sunxi/sunxi-tools")
@@ -1910,5 +1911,8 @@ bootloader) parameters.
@item @command{sunxi-pio}: Sets GPIO parameters and oscillates a GPIO
in order to be able to find it.
@item @command{sunxi-meminfo}: Prints memory bus settings.
+@item @command{sunxi-nand-image-builder}: Prepares raw NAND images.
+@item @command{sunxi-script_extractor}: Extracts script.bin from a
+running Linux 3.4 kernel.
@end enumerate")
(license license:gpl2+)))
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] gnu: Update sunxi-tools to 1.4
2016-10-26 21:21 [PATCH] gnu: Update sunxi-tools to 1.4 Danny Milosavljevic
@ 2016-10-27 5:22 ` John Darrington
2016-10-27 12:30 ` Danny Milosavljevic
2016-10-27 6:27 ` Efraim Flashner
1 sibling, 1 reply; 6+ messages in thread
From: John Darrington @ 2016-10-27 5:22 UTC (permalink / raw
To: Danny Milosavljevic; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 1267 bytes --]
On Wed, Oct 26, 2016 at 11:21:32PM +0200, Danny Milosavljevic wrote:
---
gnu/packages/admin.scm | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index d9b08ef..856d946 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -1892,7 +1893,7 @@ Kerberos and Heimdal and FAST is supported with recent MIT Kerberos.")
;; Upstream adds Makefile and config.h as dependencies
;; of all their tools which means $^ would pass them to gcc.
;; gcc won't know what to do with a Makefile.
- (("-o [$][@] [$]\\^") "-o $@ meminfo.c"))
+ (("-o [$][@] [$]\\^") "-o $@ $<"))
#t))
(delete 'configure))))
(home-page "https://github.com/linux-sunxi/sunxi-tools")
It looks to me like this change should go into a patch and be submitted upstream.
J'
--
Avoid eavesdropping. Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gnu: Update sunxi-tools to 1.4
2016-10-26 21:21 [PATCH] gnu: Update sunxi-tools to 1.4 Danny Milosavljevic
2016-10-27 5:22 ` John Darrington
@ 2016-10-27 6:27 ` Efraim Flashner
2016-10-27 12:28 ` Danny Milosavljevic
1 sibling, 1 reply; 6+ messages in thread
From: Efraim Flashner @ 2016-10-27 6:27 UTC (permalink / raw
To: Danny Milosavljevic; +Cc: guix-devel
[-- Attachment #1: Type: text/plain, Size: 3084 bytes --]
On Wed, Oct 26, 2016 at 11:21:32PM +0200, Danny Milosavljevic wrote:
> ---
> gnu/packages/admin.scm | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index d9b08ef..856d946 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm
> @@ -1859,14 +1859,14 @@ Kerberos and Heimdal and FAST is supported with recent MIT Kerberos.")
> (define-public sunxi-tools
> (package
> (name "sunxi-tools")
> - (version "1.3")
> + (version "1.4")
> (source
> (origin
> (method url-fetch)
> (uri (string-append "https://github.com/linux-sunxi/"
> "sunxi-tools/archive/v" version ".tar.gz"))
> (sha256
> - (base32 "1iazm28gws1i8sls3gxwc5p108n56ags287zmh1rpvkn2k1az81a"))
> + (base32 "1hx72cx4wj9w4c6niq0b6l3c5aj259g392z6y3a5f7fnybanq3pq"))
> (modules '((guix build utils)))
> (snippet
> ;; Remove binaries contained in the tarball which are only for the
> @@ -1882,8 +1882,9 @@ Kerberos and Heimdal and FAST is supported with recent MIT Kerberos.")
> `(#:tests? #f ; no tests exist
> #:make-flags (list (string-append "PREFIX="
> (assoc-ref %outputs "out"))
> - "TARGET_TOOLS=sunxi-pio sunxi-meminfo"
> - "CROSS_COMPILE=")
> + "TARGET_TOOLS=sunxi-pio sunxi-meminfo sunxi-script_extractor"
> + "CROSS_COMPILE="
> + "CC=gcc")
is the change in 'target-tools' necessary for the update or should/can
it be split out into a second commit?
> #:phases
> (modify-phases %standard-phases
> (add-after 'unpack 'fix-Makefile
> @@ -1892,7 +1893,7 @@ Kerberos and Heimdal and FAST is supported with recent MIT Kerberos.")
> ;; Upstream adds Makefile and config.h as dependencies
> ;; of all their tools which means $^ would pass them to gcc.
> ;; gcc won't know what to do with a Makefile.
> - (("-o [$][@] [$]\\^") "-o $@ meminfo.c"))
> + (("-o [$][@] [$]\\^") "-o $@ $<"))
> #t))
> (delete 'configure))))
> (home-page "https://github.com/linux-sunxi/sunxi-tools")
> @@ -1910,5 +1911,8 @@ bootloader) parameters.
> @item @command{sunxi-pio}: Sets GPIO parameters and oscillates a GPIO
> in order to be able to find it.
> @item @command{sunxi-meminfo}: Prints memory bus settings.
> +@item @command{sunxi-nand-image-builder}: Prepares raw NAND images.
> +@item @command{sunxi-script_extractor}: Extracts script.bin from a
> +running Linux 3.4 kernel.
> @end enumerate")
> (license license:gpl2+)))
>
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gnu: Update sunxi-tools to 1.4
2016-10-27 6:27 ` Efraim Flashner
@ 2016-10-27 12:28 ` Danny Milosavljevic
0 siblings, 0 replies; 6+ messages in thread
From: Danny Milosavljevic @ 2016-10-27 12:28 UTC (permalink / raw
To: Efraim Flashner; +Cc: guix-devel
> is the change in 'target-tools' necessary for the update or should/can
> it be split out into a second commit?
It should be split out...
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gnu: Update sunxi-tools to 1.4
2016-10-27 5:22 ` John Darrington
@ 2016-10-27 12:30 ` Danny Milosavljevic
2016-10-27 14:02 ` Ricardo Wurmus
0 siblings, 1 reply; 6+ messages in thread
From: Danny Milosavljevic @ 2016-10-27 12:30 UTC (permalink / raw
To: John Darrington; +Cc: guix-devel
> - (("-o [$][@] [$]\\^") "-o $@ meminfo.c"))
> + (("-o [$][@] [$]\\^") "-o $@ $<"))
> #t))
> (delete 'configure))))
> (home-page "https://github.com/linux-sunxi/sunxi-tools")
>
> It looks to me like this change should go into a patch and be submitted upstream.
Yes, there's an upstream issue open for it: <https://github.com/linux-sunxi/sunxi-tools/issues/70>.
I've also reported a seperate issue for an executable that doesn't get installed: <https://github.com/linux-sunxi/sunxi-tools/issues/69>.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gnu: Update sunxi-tools to 1.4
2016-10-27 12:30 ` Danny Milosavljevic
@ 2016-10-27 14:02 ` Ricardo Wurmus
0 siblings, 0 replies; 6+ messages in thread
From: Ricardo Wurmus @ 2016-10-27 14:02 UTC (permalink / raw
To: Danny Milosavljevic; +Cc: guix-devel
Danny Milosavljevic <dannym@scratchpost.org> writes:
>> - (("-o [$][@] [$]\\^") "-o $@ meminfo.c"))
>> + (("-o [$][@] [$]\\^") "-o $@ $<"))
>> #t))
>> (delete 'configure))))
>> (home-page "https://github.com/linux-sunxi/sunxi-tools")
>>
>> It looks to me like this change should go into a patch and be submitted upstream.
>
> Yes, there's an upstream issue open for it: <https://github.com/linux-sunxi/sunxi-tools/issues/70>.
>
> I've also reported a seperate issue for an executable that doesn't get installed: <https://github.com/linux-sunxi/sunxi-tools/issues/69>.
In this case please add a comment referencing the issue.
Thanks!
~~ Ricardo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-27 14:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-26 21:21 [PATCH] gnu: Update sunxi-tools to 1.4 Danny Milosavljevic
2016-10-27 5:22 ` John Darrington
2016-10-27 12:30 ` Danny Milosavljevic
2016-10-27 14:02 ` Ricardo Wurmus
2016-10-27 6:27 ` Efraim Flashner
2016-10-27 12:28 ` Danny Milosavljevic
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).