From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodoros Foradis Subject: [PATCH v2 0/3] gnu: Add gdb-arm-none-eabi and openocd. Date: Thu, 27 Oct 2016 00:08:04 +0300 Message-ID: <20161026210807.27390-1-theodoros.for@openmailbox.org> References: Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46286) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bzVUC-00008F-1U for guix-devel@gnu.org; Wed, 26 Oct 2016 17:11:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bzVU8-0002Pq-LP for guix-devel@gnu.org; Wed, 26 Oct 2016 17:11:48 -0400 Received: from smtp8.openmailbox.org ([62.4.1.42]:47768) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bzVU8-0002PE-DC for guix-devel@gnu.org; Wed, 26 Oct 2016 17:11:44 -0400 In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org Hello Dadiv, I am posting a version 2 of the patch series, making the changes you suggested for hidapi plus the following. The git commit was changed to a more recent one. A guix package revision was added, for future package updates. David Craven writes: > Hi Theodoros, > > Do we really need this patch? Is there a reason why it hasn't been > upstreamed yet? > I updated the patch for nrf52 support, to the version which has been tested, and is reviewd to go in master as well. Additional info, in the patch header. This patch is not needed for openocd to work. It adds support for a board I am using, and since it's been tested, I think it's nice to have in guix. > (add-before 'configure 'bootstrap > + (lambda _ > + (system* "aclocal") > + (system* "libtoolize" "--automake" "--copy") > + (system* "autoconf") > + (system* "autoheader") > + (system* "automake" "--gnu" "--add-missing" "--copy") > + #t)) > > Why not (add-before 'configure 'autoreconf > (lambda _ > (zero? (system* "autoreconf" "-vfi")) > fixed > I prefer indenting like this as is done in most of the codebase: > > + (inputs > `(("libusb" ,libusb) > + ("libusb-compat" ,libusb-compat) > + ("libftdi" ,libftdi) > + ("hidapi" ,hidapi))) > + (native-inputs > `(("autoconf" ,autoconf) > + ("libtool" ,libtool) > + ("automake" ,automake) > + ("pkg-config" ,pkg-config))) > fixed > It would also be nice if the inputs where ordered alphabetically. > done > Thanks for the patch, looking good!! You don't need to resubmit > (unless someone else has more objections :). > > David Thanks for your input. Theodoros Foradis (3): gnu: Add gdb-arm-none-eabi. gnu: Add hidapi. gnu: Add openocd. gnu/local.mk | 2 + gnu/packages/embedded.scm | 83 +++++++++ gnu/packages/hidapi.scm | 63 +++++++ gnu/packages/patches/openocd-nrf52.patch | 843 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 991 insertions(+) -- Theodoros Foradis