From: Leo Famulari <leo@famulari.name>
To: Kei Kebreau <kei@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add libjxr.
Date: Fri, 21 Oct 2016 19:58:59 -0400 [thread overview]
Message-ID: <20161021235859.GA9570@jasmine> (raw)
In-Reply-To: <87eg39qvjh.fsf@openmailbox.org>
[-- Attachment #1: Type: text/plain, Size: 1500 bytes --]
On Fri, Oct 21, 2016 at 04:47:14PM -0400, Kei Kebreau wrote:
> This is a patch I think we need before fixing up freeimage. Thoughts?
Thanks for working on this!
> + (uri (string-append "mirror://debian/pool/main/j/jxrlib/jxrlib_"
> + version ".orig.tar.gz"))
Why not download it from the upstream site? We prefer to do that when
possible.
https://jxrlib.codeplex.com/releases/view/107208
> + (license
> + (license:non-copyleft
> + "file://Makefile"
> + "See the header of the Makefile in the distribution."))
That looks like a 2 clause BSD license:
https://opensource.org/licenses/BSD-2-Clause
> diff --git a/gnu/packages/patches/libjxr-fix-typos.patch b/gnu/packages/patches/libjxr-fix-typos.patch
> new file mode 100644
> index 0000000..3c051dd
> --- /dev/null
> +++ b/gnu/packages/patches/libjxr-fix-typos.patch
> @@ -0,0 +1,60 @@
> +Description: Fix typos and remove some warnings
> +Author: Mathieu Malaterre <malat@debian.org>
Can you include a link to the source of this patch?
> diff --git a/gnu/packages/patches/libjxr-use-cmake.patch b/gnu/packages/patches/libjxr-use-cmake.patch
> new file mode 100644
> index 0000000..cb5919e
> --- /dev/null
> +++ b/gnu/packages/patches/libjxr-use-cmake.patch
> @@ -0,0 +1,143 @@
> +Description: Prefer a cmake based build system
> +Author: Mathieu Malaterre <malat@debian.org>
> +Forwarded: https://jxrlib.codeplex.com/discussions/440294
Why doesn't upstream's build system work?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-10-21 23:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 20:47 [PATCH] gnu: Add libjxr Kei Kebreau
2016-10-21 23:58 ` Leo Famulari [this message]
2016-10-22 8:33 ` Kei Kebreau
2016-10-23 21:29 ` Leo Famulari
2016-10-28 13:40 ` Ludovic Courtès
2016-10-29 4:46 ` Kei Kebreau
2016-10-29 21:02 ` Ludovic Courtès
2016-10-30 15:31 ` Kei Kebreau
2016-11-03 13:36 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021235859.GA9570@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=kei@openmailbox.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).