From: ludo@gnu.org (Ludovic Courtès)
Subject: Re: [PATCH] gnu: Add coda.
Date: Wed, 19 Oct 2016 22:13:42 +0200

>> +    (native-search-paths
>> +     (list (search-path-specification
>> +            (variable "PYTHONPATH")
>> +            (files '("lib/python3.4/site-packages")))))
>
> Unless I’m mistaken this is not needed: this ‘native-search-paths’ 
> entry
> belongs in Python itself, not in users of Python.

I used ipython to test the interface, and noticed the PYTHONPATH 
setting was missing.  That's why I added it here.  So probably this 
native-search-paths entry could/should be added to the ipython 
package?

>> +    (synopsis "Common interface to various earth observation data 
>> formats")
>> +    (description
>> +     "The Common Data Access toolbox (CODA) provides a set of 
>> interfaces for
>> +reading remote sensing data from earth observation data files.  
>> These
>> +interfaces consist of command line applications, libraries, 
>> interfaces to
>> +scientific applications (such as IDL and MATLAB), and interfaces 
>> to
>
> Let’s remove MATLAB; we can replace it with Octave if it’s valid.

I removed IDL as well, because it's the same story as Matlab 
(proprietary scripting language for scientific applications).  I 
don't think there's an Octave interface, unless Octave can 
automatically use interfaces written for Matlab (unlikely? I have no 
experience with either).

>> +    (license license:gpl2)))
>
> Version 2 only?  That is, is the “or any later version” wording 
> missing
> from license headers?

gpl2+, indeed.

I've attached an updated patch.

cheers,

Thomas