From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 2/4] gnu: notmuch: Enable tests.
Date: Mon, 17 Oct 2016 14:29:13 -0400
Message-ID: <20161017182912.GC31629@jasmine>
References: <20161017165506.17750-1-mbakke@fastmail.com>
	<20161017165506.17750-3-mbakke@fastmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35097)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bwCf4-0008Lm-NW
	for guix-devel@gnu.org; Mon, 17 Oct 2016 14:29:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bwCf0-0005ZR-JR
	for guix-devel@gnu.org; Mon, 17 Oct 2016 14:29:22 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:42144)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <leo@famulari.name>) id 1bwCf0-0005ZM-Fg
	for guix-devel@gnu.org; Mon, 17 Oct 2016 14:29:18 -0400
Content-Disposition: inline
In-Reply-To: <20161017165506.17750-3-mbakke@fastmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org

On Mon, Oct 17, 2016 at 05:55:04PM +0100, Marius Bakke wrote:
> * gnu/packages/patches/notmuch-emacs-25-compatibility-fix.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Register it.
> * gnu/packages/mail.scm (notmuch)[arguments]: Add verbose make flags.
>   Add phase 'patch-notmuch-lib.el' to fix hard-coded /bin/sh.
>   Add 'prepare-test-environment' phase to patch test shebangs and set
>   environment.
> [native-inputs]: Change from 'emacs-minimal' to 'emacs-no-x'. Add dtach,
>   gnupg, man, perl and which.

A true nit-pick, but all those lines should start at column 0 rather
than being indented.

> +              (patches
> +               ;; This is included in the next release.
> +               ;; https://notmuchmail.org/pipermail/notmuch/2016/023309.html
> +               (search-patches "notmuch-emacs-25-compatibility-fix.patch"))))

Please mention the use of this patch in the commit changelog.

> +       ;; The following are required for tests only.
> +       ("which" ,which)
> +       ("dtach" ,dtach)
> +       ("gnupg" ,gnupg)
> +       ("man" ,man-db)
> +       ("perl" ,perl)))

Can you check if these inputs are referenced by the output? Ideally
not...

$ guix gc --references $(./pre-inst-env guix build notmuch)

> diff --git a/gnu/packages/patches/notmuch-emacs-25-compatibility-fix.patch b/gnu/packages/patches/notmuch-emacs-25-compatibility-fix.patch
> new file mode 100644
> index 0000000..456b345
> --- /dev/null
> +++ b/gnu/packages/patches/notmuch-emacs-25-compatibility-fix.patch
> @@ -0,0 +1,43 @@
> +From f575a346df09c82691bb9e7c462836d982fe31f7 Mon Sep 17 00:00:00 2001
> +From: David Bremner <david@tethera.net>
> +Date: Sun, 9 Oct 2016 19:30:44 -0300
> +Subject: [PATCH] emacs/show: force notmuch-show-buttonise-links to act on
> + lines

If possible, please add a hyperlink to the source of the patch. Ideally,
to a Git commit in a web-based Git repo interface.

Not knowing Emacs Lisp, I can't comment on the patch itself.