From: Leo Famulari <leo@famulari.name>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/4] gnu: notmuch: Enable tests.
Date: Mon, 17 Oct 2016 14:29:13 -0400 [thread overview]
Message-ID: <20161017182912.GC31629@jasmine> (raw)
In-Reply-To: <20161017165506.17750-3-mbakke@fastmail.com>
On Mon, Oct 17, 2016 at 05:55:04PM +0100, Marius Bakke wrote:
> * gnu/packages/patches/notmuch-emacs-25-compatibility-fix.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Register it.
> * gnu/packages/mail.scm (notmuch)[arguments]: Add verbose make flags.
> Add phase 'patch-notmuch-lib.el' to fix hard-coded /bin/sh.
> Add 'prepare-test-environment' phase to patch test shebangs and set
> environment.
> [native-inputs]: Change from 'emacs-minimal' to 'emacs-no-x'. Add dtach,
> gnupg, man, perl and which.
A true nit-pick, but all those lines should start at column 0 rather
than being indented.
> + (patches
> + ;; This is included in the next release.
> + ;; https://notmuchmail.org/pipermail/notmuch/2016/023309.html
> + (search-patches "notmuch-emacs-25-compatibility-fix.patch"))))
Please mention the use of this patch in the commit changelog.
> + ;; The following are required for tests only.
> + ("which" ,which)
> + ("dtach" ,dtach)
> + ("gnupg" ,gnupg)
> + ("man" ,man-db)
> + ("perl" ,perl)))
Can you check if these inputs are referenced by the output? Ideally
not...
$ guix gc --references $(./pre-inst-env guix build notmuch)
> diff --git a/gnu/packages/patches/notmuch-emacs-25-compatibility-fix.patch b/gnu/packages/patches/notmuch-emacs-25-compatibility-fix.patch
> new file mode 100644
> index 0000000..456b345
> --- /dev/null
> +++ b/gnu/packages/patches/notmuch-emacs-25-compatibility-fix.patch
> @@ -0,0 +1,43 @@
> +From f575a346df09c82691bb9e7c462836d982fe31f7 Mon Sep 17 00:00:00 2001
> +From: David Bremner <david@tethera.net>
> +Date: Sun, 9 Oct 2016 19:30:44 -0300
> +Subject: [PATCH] emacs/show: force notmuch-show-buttonise-links to act on
> + lines
If possible, please add a hyperlink to the source of the patch. Ideally,
to a Git commit in a web-based Git repo interface.
Not knowing Emacs Lisp, I can't comment on the patch itself.
next prev parent reply other threads:[~2016-10-17 18:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 16:55 [PATCH 0/4] Notmuch and Xapian update Marius Bakke
2016-10-17 16:55 ` [PATCH 1/4] gnu: notmuch: Update to 0.23 Marius Bakke
2016-10-17 17:58 ` Leo Famulari
2016-10-17 18:43 ` Marius Bakke
2016-10-17 16:55 ` [PATCH 2/4] gnu: notmuch: Enable tests Marius Bakke
2016-10-17 18:29 ` Leo Famulari [this message]
2016-10-17 18:56 ` Marius Bakke
2016-10-17 16:55 ` [PATCH 3/4] gnu: xapian: Use 'modify-phases' Marius Bakke
2016-10-17 18:00 ` Leo Famulari
2016-10-17 18:50 ` Marius Bakke
2016-10-17 16:55 ` [PATCH 4/4] gnu: xapian: Update to 1.4.0 Marius Bakke
2016-10-17 19:49 ` Leo Famulari
2016-10-18 21:55 ` Marius Bakke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161017182912.GC31629@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).