From: Leo Famulari <leo@famulari.name>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 5/5] guix: python-build-system: Fix an outdated comment.
Date: Wed, 12 Oct 2016 12:03:43 -0400 [thread overview]
Message-ID: <20161012160343.GE31109@jasmine> (raw)
In-Reply-To: <1476105003-29538-6-git-send-email-h.goebel@crazy-compilers.com>
On Mon, Oct 10, 2016 at 03:10:03PM +0200, Hartmut Goebel wrote:
> ---
> guix/build/python-build-system.scm | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
> index 9109fb4..e906e60 100644
> --- a/guix/build/python-build-system.scm
> +++ b/guix/build/python-build-system.scm
> @@ -137,8 +137,7 @@ installed with setuptools."
> #t))
>
> (define %standard-phases
> - ;; 'configure' and 'build' phases are not needed. Everything is done during
> - ;; 'install'.
> + ;; 'configure' phase is not needed.
I have no real comment because I don't know the python-build-system well
enough. Is the sentence about 'install' no longer accurate?
next prev parent reply other threads:[~2016-10-12 16:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 13:09 [PATCH 0/5] Some simple or even trivial changes Hartmut Goebel
2016-10-10 13:09 ` [PATCH 1/5] gnu: python2-pytest-runner: Remove duplicate definition Hartmut Goebel
2016-10-12 15:53 ` Leo Famulari
2016-10-12 20:10 ` More duplicate package definitions Danny Milosavljevic
2016-10-13 13:17 ` Hartmut Goebel
2016-10-13 22:39 ` Leo Famulari
2016-10-14 11:10 ` Ricardo Wurmus
2016-10-10 13:10 ` [PATCH 2/5] gnu: python-pytest-xdist: Remove python byte-code files from source Hartmut Goebel
2016-10-11 20:24 ` Danny Milosavljevic
2016-10-12 15:56 ` Leo Famulari
2016-10-10 13:10 ` [PATCH 3/5] gnu: python-zope-testing: Strip byte-code and garbage " Hartmut Goebel
2016-10-12 15:59 ` Leo Famulari
2016-10-10 13:10 ` [PATCH 4/5] gnu: python.scm: Update some home-page urls and descriptions Hartmut Goebel
2016-10-12 16:01 ` Leo Famulari
2016-10-13 8:36 ` Hartmut Goebel
2016-10-13 20:14 ` Ludovic Courtès
2016-10-14 8:03 ` Hartmut Goebel
2016-10-10 13:10 ` [PATCH 5/5] guix: python-build-system: Fix an outdated comment Hartmut Goebel
2016-10-12 16:03 ` Leo Famulari [this message]
2016-10-13 7:32 ` Hartmut Goebel
2016-10-13 20:06 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161012160343.GE31109@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=h.goebel@crazy-compilers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).