From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 3/5] gnu: python-zope-testing: Strip byte-code and
	garbage from source.
Date: Wed, 12 Oct 2016 11:59:12 -0400
Message-ID: <20161012155912.GC31109@jasmine>
References: <1476105003-29538-1-git-send-email-h.goebel@crazy-compilers.com>
	<1476105003-29538-4-git-send-email-h.goebel@crazy-compilers.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33303)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1buLwG-0004gn-Sn
	for guix-devel@gnu.org; Wed, 12 Oct 2016 11:59:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1buLwB-0007di-0d
	for guix-devel@gnu.org; Wed, 12 Oct 2016 11:59:27 -0400
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:55588)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1buLw9-0007ap-QB
	for guix-devel@gnu.org; Wed, 12 Oct 2016 11:59:22 -0400
Content-Disposition: inline
In-Reply-To: <1476105003-29538-4-git-send-email-h.goebel@crazy-compilers.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org

On Mon, Oct 10, 2016 at 03:10:01PM +0200, Hartmut Goebel wrote:
> * gnu/package/python.scm (python-zope-testing): Add snippet to strip
>   byte-code and garbage from source.

Again, mention both python-zope-testing and python2-zope-testing, and
indicate that the changes are in [source].

Also, I think we should be more descriptive than "garbage".

> ---
>  gnu/packages/python.scm | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 345c6a7..a289093 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -6647,7 +6647,13 @@ that have uses outside of the Zope framework.")
>                             "/zope.testing/zope.testing-" version ".tar.gz"))
>         (sha256
>          (base32
> -         "1yvglxhzvhl45mndvn9gskx2ph30zz1bz7rrlyfs62fv2pvih90s"))))
> +         "1yvglxhzvhl45mndvn9gskx2ph30zz1bz7rrlyfs62fv2pvih90s"))
> +       (modules '((guix build utils)))
> +       (snippet
> +        '(begin
> +           ;; Source contains .pyc files and some garbage

Please use a complete sentence here.

> +           (for-each delete-file (find-files "." "(\\.pyc|~)$"))
> +           #t))))
>      (build-system python-build-system)
>      (native-inputs
>       `(("python-zope-exceptions" ,python-zope-exceptions)))

LGTM with the requested changes.