[PATCH] gnu: lynx: Fix GnuTLS support.

[PATCH] gnu: lynx: Fix GnuTLS support.

[Kei Kebreau]

[-- Attachment #1.1: Type: text/plain, Size: 108 bytes --]

HTTPS connections using lynx work on my machine with this patch. Would
someone else like to see about this?

[-- Attachment #1.2: 0001-gnu-lynx-Fix-GnuTLS-support.patch --]
[-- Type: text/plain, Size: 1939 bytes --]

From c18ab7b9c24f07ab86529d7f5f08f4dd21cea549 Mon Sep 17 00:00:00 2001
From: Kei Kebreau <kei@openmailbox.org>
Date: Thu, 6 Oct 2016 20:38:39 -0400
Subject: [PATCH] gnu: lynx: Fix GnuTLS support.

* gnu/packages/lynx.scm (lynx)[arguments]: Pass "--with-gnutls" in
---
 gnu/packages/lynx.scm | 28 +++++++++++++++-------------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/gnu/packages/lynx.scm b/gnu/packages/lynx.scm
index 3182b3e..71bed77 100644
--- a/gnu/packages/lynx.scm
+++ b/gnu/packages/lynx.scm
@@ -53,19 +53,21 @@
               ("gzip" ,gzip)
               ("bzip2" ,bzip2)))
     (arguments
-     `(#:configure-flags '("--with-pkg-config"
-                           "--with-screen=ncurses"
-                           "--with-zlib"
-                           "--with-bzlib"
-                           "--with-gnutls"
-                           ;; "--with-socks5"    ; XXX TODO
-                           "--enable-widec"
-                           "--enable-ascii-ctypes"
-                           "--enable-local-docs"
-                           "--enable-htmlized-cfg"
-                           "--enable-gzip-help"
-                           "--enable-nls"
-                           "--enable-ipv6")
+     `(#:configure-flags
+       (let ((gnutls (assoc-ref %build-inputs "gnutls")))
+         `("--with-pkg-config"
+           "--with-screen=ncurses"
+           "--with-zlib"
+           "--with-bzlib"
+           ,(string-append "--with-gnutls=" gnutls)
+           ;; "--with-socks5"    ; XXX TODO
+           "--enable-widec"
+           "--enable-ascii-ctypes"
+           "--enable-local-docs"
+           "--enable-htmlized-cfg"
+           "--enable-gzip-help"
+           "--enable-nls"
+           "--enable-ipv6"))
        #:tests? #f  ; no check target
        #:phases (alist-replace
                  'install
-- 
2.10.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: [PATCH] gnu: lynx: Fix GnuTLS support.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1192 bytes --]

On Thu, Oct 06, 2016 at 08:48:31PM -0400, Kei Kebreau wrote:
> HTTPS connections using lynx work on my machine with this patch. Would
> someone else like to see about this?

Thanks for working on this!

It still fails for me, but in a different way than before [0]:

-----
$ lynx https://famulari.name                   

Looking up famulari.name
Making HTTPS connection to famulari.name
Retrying connection without TLS.
Looking up famulari.name
Making HTTPS connection to famulari.name
Alert!: Unable to make secure connection to remote host.

lynx: Can't access startfile https://famulari.name/
-----

I assume that I'm missing some environment variable on this Guix /
Debian system. Any ideas?

If it works for you, I'd say go for it.

> From c18ab7b9c24f07ab86529d7f5f08f4dd21cea549 Mon Sep 17 00:00:00 2001
> From: Kei Kebreau <kei@openmailbox.org>
> Date: Thu, 6 Oct 2016 20:38:39 -0400
> Subject: [PATCH] gnu: lynx: Fix GnuTLS support.
> 
> * gnu/packages/lynx.scm (lynx)[arguments]: Pass "--with-gnutls" in

I think this commit message is truncated.

[0] Without this patch, lynx says:
Alert!: This client does not contain support for HTTPS URLs.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] gnu: lynx: Fix GnuTLS support.

[Tobias Geerinckx-Rice]

[-- Attachment #1.1: Type: text/plain, Size: 940 bytes --]

Kei,

On 07/10/16 03:28, Leo Famulari wrote:
> On Thu, Oct 06, 2016 at 08:48:31PM -0400, Kei Kebreau wrote:
>> HTTPS connections using lynx work on my machine with this patch. Would
>> someone else like to see about this?
> 
> Thanks for working on this!

+1!

On 07/10/16 03:28, Leo Famulari wrote:
> It still fails for me, but in a different way than before:
> $ lynx https://famulari.name

On my pure GuixSD machine,

  $ lynx https://tobias.gr

suffers the same fate. Interestingly,

  $ lynx https://google.com

works just fin— Wait a minute, this all sounds terribly familiar.

https://lists.gnu.org/archive/html/guix-devel/2016-03/msg00135.html

I gave up at this point, as Guix was new and scary and my need for Lynx
vanished anyway. It looks like there might some Lynx-specific quirks
involved as well (e.g. ‘--with-gnutls=’ sufficing, at least back then).

Kind regards/good luck,

T G-R


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH] gnu: lynx: Fix GnuTLS support.

[Tobias Geerinckx-Rice]

[-- Attachment #1.1: Type: text/plain, Size: 253 bytes --]

On 07/10/16 03:56, Tobias Geerinckx-Rice wrote:
> Interestingly,
> 
>   $ lynx https://google.com
> 
> works just fin—

(In the interest of balance,

  $ lynx https://duckduckgo.com

works just fin– as well.)

Kind regards,

T G-R


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [PATCH] gnu: lynx: Fix GnuTLS support.

[ng0]

Tobias Geerinckx-Rice <me@tobias.gr> writes:

> [ Unknown signature status ]
> On 07/10/16 03:56, Tobias Geerinckx-Rice wrote:
>> Interestingly,
>> 
>>   $ lynx https://google.com
>> 
>> works just fin—
>
> (In the interest of balance,
>
>   $ lynx https://duckduckgo.com
>
> works just fin– as well.)
>
> Kind regards,
>
> T G-R
>

Without knowing all the history of this bug, could it be related to the
curl problem (which currently keeps my darcs, pbpst, and probably
something else from getting into master)? Do we need some environment
variable to pass or work into lynx to make it work for us? or patch lynx
at its source?

Re: [PATCH] gnu: lynx: Fix GnuTLS support.

[Kei Kebreau]

[-- Attachment #1.1: Type: text/plain, Size: 1459 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Thu, Oct 06, 2016 at 08:48:31PM -0400, Kei Kebreau wrote:
>> HTTPS connections using lynx work on my machine with this patch. Would
>> someone else like to see about this?
>
> Thanks for working on this!
>
> It still fails for me, but in a different way than before [0]:
>
> -----
> $ lynx https://famulari.name                   
>
> Looking up famulari.name
> Making HTTPS connection to famulari.name
> Retrying connection without TLS.
> Looking up famulari.name
> Making HTTPS connection to famulari.name
> Alert!: Unable to make secure connection to remote host.
>
> lynx: Can't access startfile https://famulari.name/
> -----
>
> I assume that I'm missing some environment variable on this Guix /
> Debian system. Any ideas?
>
> If it works for you, I'd say go for it.
>
>> From c18ab7b9c24f07ab86529d7f5f08f4dd21cea549 Mon Sep 17 00:00:00 2001
>> From: Kei Kebreau <kei@openmailbox.org>
>> Date: Thu, 6 Oct 2016 20:38:39 -0400
>> Subject: [PATCH] gnu: lynx: Fix GnuTLS support.
>> 
>> * gnu/packages/lynx.scm (lynx)[arguments]: Pass "--with-gnutls" in
>
> I think this commit message is truncated.
>
> [0] Without this patch, lynx says:
> Alert!: This client does not contain support for HTTPS URLs.

I get the same problem here. Lynx does mention that GnuTLS support is
experimental. Your and Tobias' page work using OpenSSL instead. Try the
new patch attached.

[-- Attachment #1.2: 0001-gnu-lynx-Support-HTTPS-SSL-connections.patch --]
[-- Type: text/plain, Size: 2349 bytes --]

From ee3a889e6902686de4d7c949afcb8cd4a810bd0f Mon Sep 17 00:00:00 2001
From: Kei Kebreau <kei@openmailbox.org>
Date: Fri, 7 Oct 2016 10:36:11 -0400
Subject: [PATCH] gnu: lynx: Support HTTPS (SSL) connections

* gnu/packages/lynx.scm (lynx)[inputs]: Add 'openssl' and remove 'gnutls'.
[arguments]: Add configure flags for OpenSSL support; remove configure flags
for GnuTLS support.
---
 gnu/packages/lynx.scm | 30 ++++++++++++++++--------------
 1 file changed, 16 insertions(+), 14 deletions(-)

diff --git a/gnu/packages/lynx.scm b/gnu/packages/lynx.scm
index 3182b3e..84e9038 100644
--- a/gnu/packages/lynx.scm
+++ b/gnu/packages/lynx.scm
@@ -46,26 +46,28 @@
                      ("perl" ,perl)))
     (inputs `(("ncurses" ,ncurses)
               ("libidn" ,libidn)
-              ("gnutls" ,gnutls)
+              ("openssl" ,openssl)
               ("libgcrypt" ,libgcrypt)
               ("unzip" ,unzip)
               ("zlib" ,zlib)
               ("gzip" ,gzip)
               ("bzip2" ,bzip2)))
     (arguments
-     `(#:configure-flags '("--with-pkg-config"
-                           "--with-screen=ncurses"
-                           "--with-zlib"
-                           "--with-bzlib"
-                           "--with-gnutls"
-                           ;; "--with-socks5"    ; XXX TODO
-                           "--enable-widec"
-                           "--enable-ascii-ctypes"
-                           "--enable-local-docs"
-                           "--enable-htmlized-cfg"
-                           "--enable-gzip-help"
-                           "--enable-nls"
-                           "--enable-ipv6")
+     `(#:configure-flags
+       (let ((openssl (assoc-ref %build-inputs "openssl")))
+         `("--with-pkg-config"
+           "--with-screen=ncurses"
+           "--with-zlib"
+           "--with-bzlib"
+           ,(string-append "--with-ssl=" openssl)
+           ;; "--with-socks5"    ; XXX TODO
+           "--enable-widec"
+           "--enable-ascii-ctypes"
+           "--enable-local-docs"
+           "--enable-htmlized-cfg"
+           "--enable-gzip-help"
+           "--enable-nls"
+           "--enable-ipv6"))
        #:tests? #f  ; no check target
        #:phases (alist-replace
                  'install
-- 
2.10.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: [PATCH] gnu: lynx: Fix GnuTLS support.

[ng0]

Hi,

Kei I think you need to consider packaging one of the "pre" versions of
lynx. I understand we are fixed on packaging this with gnutls, so if you
read the changelog of the recent pre versions releases, you will
discover that there was work on gnutls support. If you don't want to
package pre version itself, there might be patches directly. I don't
know how this all works together and it wasn't my intention to find out
when I looked into this, but we should really consider to package recent
pre release of lynx. Note that this is not dev, dev is more experimental
than pre.

Kei Kebreau <kei@openmailbox.org> writes:

> [ Unknown signature status ]
> Leo Famulari <leo@famulari.name> writes:
>
>> On Thu, Oct 06, 2016 at 08:48:31PM -0400, Kei Kebreau wrote:
>>> HTTPS connections using lynx work on my machine with this patch. Would
>>> someone else like to see about this?
>>
>> Thanks for working on this!
>>
>> It still fails for me, but in a different way than before [0]:
>>
>> -----
>> $ lynx https://famulari.name                   
>>
>> Looking up famulari.name
>> Making HTTPS connection to famulari.name
>> Retrying connection without TLS.
>> Looking up famulari.name
>> Making HTTPS connection to famulari.name
>> Alert!: Unable to make secure connection to remote host.
>>
>> lynx: Can't access startfile https://famulari.name/
>> -----
>>
>> I assume that I'm missing some environment variable on this Guix /
>> Debian system. Any ideas?
>>
>> If it works for you, I'd say go for it.
>>
>>> From c18ab7b9c24f07ab86529d7f5f08f4dd21cea549 Mon Sep 17 00:00:00 2001
>>> From: Kei Kebreau <kei@openmailbox.org>
>>> Date: Thu, 6 Oct 2016 20:38:39 -0400
>>> Subject: [PATCH] gnu: lynx: Fix GnuTLS support.
>>> 
>>> * gnu/packages/lynx.scm (lynx)[arguments]: Pass "--with-gnutls" in
>>
>> I think this commit message is truncated.
>>
>> [0] Without this patch, lynx says:
>> Alert!: This client does not contain support for HTTPS URLs.
>
> I get the same problem here. Lynx does mention that GnuTLS support is
> experimental. Your and Tobias' page work using OpenSSL instead. Try the
> new patch attached.
> From ee3a889e6902686de4d7c949afcb8cd4a810bd0f Mon Sep 17 00:00:00 2001
> From: Kei Kebreau <kei@openmailbox.org>
> Date: Fri, 7 Oct 2016 10:36:11 -0400
> Subject: [PATCH] gnu: lynx: Support HTTPS (SSL) connections
>
> * gnu/packages/lynx.scm (lynx)[inputs]: Add 'openssl' and remove 'gnutls'.
> [arguments]: Add configure flags for OpenSSL support; remove configure flags
> for GnuTLS support.
> ---
>  gnu/packages/lynx.scm | 30 ++++++++++++++++--------------
>  1 file changed, 16 insertions(+), 14 deletions(-)
>
> diff --git a/gnu/packages/lynx.scm b/gnu/packages/lynx.scm
> index 3182b3e..84e9038 100644
> --- a/gnu/packages/lynx.scm
> +++ b/gnu/packages/lynx.scm
> @@ -46,26 +46,28 @@
>                       ("perl" ,perl)))
>      (inputs `(("ncurses" ,ncurses)
>                ("libidn" ,libidn)
> -              ("gnutls" ,gnutls)
> +              ("openssl" ,openssl)
>                ("libgcrypt" ,libgcrypt)
>                ("unzip" ,unzip)
>                ("zlib" ,zlib)
>                ("gzip" ,gzip)
>                ("bzip2" ,bzip2)))
>      (arguments
> -     `(#:configure-flags '("--with-pkg-config"
> -                           "--with-screen=ncurses"
> -                           "--with-zlib"
> -                           "--with-bzlib"
> -                           "--with-gnutls"
> -                           ;; "--with-socks5"    ; XXX TODO
> -                           "--enable-widec"
> -                           "--enable-ascii-ctypes"
> -                           "--enable-local-docs"
> -                           "--enable-htmlized-cfg"
> -                           "--enable-gzip-help"
> -                           "--enable-nls"
> -                           "--enable-ipv6")
> +     `(#:configure-flags
> +       (let ((openssl (assoc-ref %build-inputs "openssl")))
> +         `("--with-pkg-config"
> +           "--with-screen=ncurses"
> +           "--with-zlib"
> +           "--with-bzlib"
> +           ,(string-append "--with-ssl=" openssl)
> +           ;; "--with-socks5"    ; XXX TODO
> +           "--enable-widec"
> +           "--enable-ascii-ctypes"
> +           "--enable-local-docs"
> +           "--enable-htmlized-cfg"
> +           "--enable-gzip-help"
> +           "--enable-nls"
> +           "--enable-ipv6"))
>         #:tests? #f  ; no check target
>         #:phases (alist-replace
>                   'install
> -- 
> 2.10.0
>

-- 

Re: [PATCH] gnu: lynx: Fix GnuTLS support.

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 784 bytes --]

ng0 <ngillmann@runbox.com> writes:

> Hi,
>
> Kei I think you need to consider packaging one of the "pre" versions of
> lynx. I understand we are fixed on packaging this with gnutls, so if you
> read the changelog of the recent pre versions releases, you will
> discover that there was work on gnutls support. If you don't want to
> package pre version itself, there might be patches directly. I don't
> know how this all works together and it wasn't my intention to find out
> when I looked into this, but we should really consider to package recent
> pre release of lynx. Note that this is not dev, dev is more experimental
> than pre.
>

I only see lynx 2.8.9 development tarballs. I don't have a problem
targeting those temporarily if it is acceptable to package it and it works.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: [PATCH] gnu: lynx: Fix GnuTLS support.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

On Fri, Oct 07, 2016 at 10:42:38AM -0400, Kei Kebreau wrote:
> I get the same problem here. Lynx does mention that GnuTLS support is
> experimental. Your and Tobias' page work using OpenSSL instead. Try the
> new patch attached.

> From ee3a889e6902686de4d7c949afcb8cd4a810bd0f Mon Sep 17 00:00:00 2001
> From: Kei Kebreau <kei@openmailbox.org>
> Date: Fri, 7 Oct 2016 10:36:11 -0400
> Subject: [PATCH] gnu: lynx: Support HTTPS (SSL) connections
> 
> * gnu/packages/lynx.scm (lynx)[inputs]: Add 'openssl' and remove 'gnutls'.
> [arguments]: Add configure flags for OpenSSL support; remove configure flags
> for GnuTLS support.

Thanks, this works for me.

I think it's fine to use the "dev" releases with GnuTLS too. Debian and
Fedora both use them.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] gnu: lynx: Fix GnuTLS support.

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Fri, Oct 07, 2016 at 10:42:38AM -0400, Kei Kebreau wrote:
>> I get the same problem here. Lynx does mention that GnuTLS support is
>> experimental. Your and Tobias' page work using OpenSSL instead. Try the
>> new patch attached.
>
>> From ee3a889e6902686de4d7c949afcb8cd4a810bd0f Mon Sep 17 00:00:00 2001
>> From: Kei Kebreau <kei@openmailbox.org>
>> Date: Fri, 7 Oct 2016 10:36:11 -0400
>> Subject: [PATCH] gnu: lynx: Support HTTPS (SSL) connections
>> 
>> * gnu/packages/lynx.scm (lynx)[inputs]: Add 'openssl' and remove 'gnutls'.
>> [arguments]: Add configure flags for OpenSSL support; remove configure flags
>> for GnuTLS support.
>
> Thanks, this works for me.
>
> I think it's fine to use the "dev" releases with GnuTLS too. Debian and
> Fedora both use them.

I can confirm that lynx 2.8.9dev.9 works properly with GnuTLS. Should we
use the current stable release with OpenSSL or the development release
with GnuTLS? And if we use the development release, should I submit the
patches as a single version bump with the necessary small adjustments?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: [PATCH] gnu: lynx: Fix GnuTLS support.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1496 bytes --]

On Sun, Oct 09, 2016 at 01:55:10PM -0400, Kei Kebreau wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Fri, Oct 07, 2016 at 10:42:38AM -0400, Kei Kebreau wrote:
> >> I get the same problem here. Lynx does mention that GnuTLS support is
> >> experimental. Your and Tobias' page work using OpenSSL instead. Try the
> >> new patch attached.
> >
> >> From ee3a889e6902686de4d7c949afcb8cd4a810bd0f Mon Sep 17 00:00:00 2001
> >> From: Kei Kebreau <kei@openmailbox.org>
> >> Date: Fri, 7 Oct 2016 10:36:11 -0400
> >> Subject: [PATCH] gnu: lynx: Support HTTPS (SSL) connections
> >> 
> >> * gnu/packages/lynx.scm (lynx)[inputs]: Add 'openssl' and remove 'gnutls'.
> >> [arguments]: Add configure flags for OpenSSL support; remove configure flags
> >> for GnuTLS support.
> >
> > Thanks, this works for me.
> >
> > I think it's fine to use the "dev" releases with GnuTLS too. Debian and
> > Fedora both use them.
> 
> I can confirm that lynx 2.8.9dev.9 works properly with GnuTLS. Should we
> use the current stable release with OpenSSL or the development release
> with GnuTLS? And if we use the development release, should I submit the
> patches as a single version bump with the necessary small adjustments?

I would do it all in one: update to 2.8.9dev.9 and correct the configure
flags so it works correctly. I think that "update" and "make the updated
version work correctly" belong in the same commit since one change
doesn't make sense without the other.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] gnu: lynx: Fix GnuTLS support.

[Kei Kebreau]

[-- Attachment #1.1: Type: text/plain, Size: 1638 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Sun, Oct 09, 2016 at 01:55:10PM -0400, Kei Kebreau wrote:
>> Leo Famulari <leo@famulari.name> writes:
>> 
>> > On Fri, Oct 07, 2016 at 10:42:38AM -0400, Kei Kebreau wrote:
>> >> I get the same problem here. Lynx does mention that GnuTLS support is
>> >> experimental. Your and Tobias' page work using OpenSSL instead. Try the
>> >> new patch attached.
>> >
>> >> From ee3a889e6902686de4d7c949afcb8cd4a810bd0f Mon Sep 17 00:00:00 2001
>> >> From: Kei Kebreau <kei@openmailbox.org>
>> >> Date: Fri, 7 Oct 2016 10:36:11 -0400
>> >> Subject: [PATCH] gnu: lynx: Support HTTPS (SSL) connections
>> >> 
>> >> * gnu/packages/lynx.scm (lynx)[inputs]: Add 'openssl' and remove 'gnutls'.
>> >> [arguments]: Add configure flags for OpenSSL support; remove
>> >> configure flags
>> >> for GnuTLS support.
>> >
>> > Thanks, this works for me.
>> >
>> > I think it's fine to use the "dev" releases with GnuTLS too. Debian and
>> > Fedora both use them.
>> 
>> I can confirm that lynx 2.8.9dev.9 works properly with GnuTLS. Should we
>> use the current stable release with OpenSSL or the development release
>> with GnuTLS? And if we use the development release, should I submit the
>> patches as a single version bump with the necessary small adjustments?
>
> I would do it all in one: update to 2.8.9dev.9 and correct the configure
> flags so it works correctly. I think that "update" and "make the updated
> version work correctly" belong in the same commit since one change
> doesn't make sense without the other.

Alright. Does this commit message look good to you?

[-- Attachment #1.2: 0001-gnu-lynx-Update-to-2.8.9dev.9-and-fix-GnuTLS-support.patch --]
[-- Type: text/plain, Size: 2949 bytes --]

From c08ba395fe1c1df29d8509350ee287c0832a1970 Mon Sep 17 00:00:00 2001
From: Kei Kebreau <kei@openmailbox.org>
Date: Sun, 9 Oct 2016 16:10:09 -0400
Subject: [PATCH] gnu: lynx: Update to 2.8.9dev.9 and fix GnuTLS support.

* gnu/packages/lynx.scm (lynx): Update to 2.8.9dev.9.
[arguments]: Append the path to the GnuTLS to "--with-gnutls=".
---
 gnu/packages/lynx.scm | 34 +++++++++++++++++++---------------
 1 file changed, 19 insertions(+), 15 deletions(-)

diff --git a/gnu/packages/lynx.scm b/gnu/packages/lynx.scm
index 3182b3e..6e4ed6c 100644
--- a/gnu/packages/lynx.scm
+++ b/gnu/packages/lynx.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2014 Mark H Weaver <mhw@netris.org>
+;;; Copyright © 2016 Kei Kebreau <kei@openmailbox.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -33,14 +34,15 @@
 (define-public lynx
   (package
     (name "lynx")
-    (version "2.8.8rel.2")
+    (version "2.8.9dev.9")
     (source (origin
               (method url-fetch)
               (uri (string-append
                     "http://invisible-mirror.net/archives/lynx/tarballs"
                     "/lynx" version ".tar.bz2"))
               (sha256
-               (base32 "1rxysl08acqll5b87368f04kckl8sggy1qhnq59gsxyny1ffg039"))))
+               (base32
+                "1m72ga89hywm097kazcm8w6sqrfjnl83gh31pkbhk4zhzhfpzxgh"))))
     (build-system gnu-build-system)
     (native-inputs `(("pkg-config" ,pkg-config)
                      ("perl" ,perl)))
@@ -53,19 +55,21 @@
               ("gzip" ,gzip)
               ("bzip2" ,bzip2)))
     (arguments
-     `(#:configure-flags '("--with-pkg-config"
-                           "--with-screen=ncurses"
-                           "--with-zlib"
-                           "--with-bzlib"
-                           "--with-gnutls"
-                           ;; "--with-socks5"    ; XXX TODO
-                           "--enable-widec"
-                           "--enable-ascii-ctypes"
-                           "--enable-local-docs"
-                           "--enable-htmlized-cfg"
-                           "--enable-gzip-help"
-                           "--enable-nls"
-                           "--enable-ipv6")
+     `(#:configure-flags
+       (let ((gnutls (assoc-ref %build-inputs "gnutls")))
+         `("--with-pkg-config"
+           "--with-screen=ncurses"
+           "--with-zlib"
+           "--with-bzlib"
+           ,(string-append "--with-gnutls=" gnutls)
+           ;; "--with-socks5"    ; XXX TODO
+           "--enable-widec"
+           "--enable-ascii-ctypes"
+           "--enable-local-docs"
+           "--enable-htmlized-cfg"
+           "--enable-gzip-help"
+           "--enable-nls"
+           "--enable-ipv6"))
        #:tests? #f  ; no check target
        #:phases (alist-replace
                  'install
-- 
2.10.0


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

Re: [PATCH] gnu: lynx: Fix GnuTLS support.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

On Sun, Oct 09, 2016 at 04:16:44PM -0400, Kei Kebreau wrote:
> Alright. Does this commit message look good to you?

> From c08ba395fe1c1df29d8509350ee287c0832a1970 Mon Sep 17 00:00:00 2001
> From: Kei Kebreau <kei@openmailbox.org>
> Date: Sun, 9 Oct 2016 16:10:09 -0400
> Subject: [PATCH] gnu: lynx: Update to 2.8.9dev.9 and fix GnuTLS support.
> 
> * gnu/packages/lynx.scm (lynx): Update to 2.8.9dev.9.
> [arguments]: Append the path to the GnuTLS to "--with-gnutls=".

Sure, looks good to me!

I didn't test this patch, but I assume that you have :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] gnu: lynx: Fix GnuTLS support.

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Sun, Oct 09, 2016 at 04:16:44PM -0400, Kei Kebreau wrote:
>> Alright. Does this commit message look good to you?
>
>> From c08ba395fe1c1df29d8509350ee287c0832a1970 Mon Sep 17 00:00:00 2001
>> From: Kei Kebreau <kei@openmailbox.org>
>> Date: Sun, 9 Oct 2016 16:10:09 -0400
>> Subject: [PATCH] gnu: lynx: Update to 2.8.9dev.9 and fix GnuTLS support.
>> 
>> * gnu/packages/lynx.scm (lynx): Update to 2.8.9dev.9.
>> [arguments]: Append the path to the GnuTLS to "--with-gnutls=".
>
> Sure, looks good to me!
>
> I didn't test this patch, but I assume that you have :)
Indeed I have! Pushed as fedcb99d840265824ebf7c5631c609b86560fc44.

Thanks for your help, Leo and Tobias!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]