unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Kei Kebreau <kei@openmailbox.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: lynx: Fix GnuTLS support.
Date: Sun, 9 Oct 2016 15:20:19 -0400	[thread overview]
Message-ID: <20161009192019.GB3025@jasmine> (raw)
In-Reply-To: <87shs5jtkx.fsf@openmailbox.org>

[-- Attachment #1: Type: text/plain, Size: 1496 bytes --]

On Sun, Oct 09, 2016 at 01:55:10PM -0400, Kei Kebreau wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Fri, Oct 07, 2016 at 10:42:38AM -0400, Kei Kebreau wrote:
> >> I get the same problem here. Lynx does mention that GnuTLS support is
> >> experimental. Your and Tobias' page work using OpenSSL instead. Try the
> >> new patch attached.
> >
> >> From ee3a889e6902686de4d7c949afcb8cd4a810bd0f Mon Sep 17 00:00:00 2001
> >> From: Kei Kebreau <kei@openmailbox.org>
> >> Date: Fri, 7 Oct 2016 10:36:11 -0400
> >> Subject: [PATCH] gnu: lynx: Support HTTPS (SSL) connections
> >> 
> >> * gnu/packages/lynx.scm (lynx)[inputs]: Add 'openssl' and remove 'gnutls'.
> >> [arguments]: Add configure flags for OpenSSL support; remove configure flags
> >> for GnuTLS support.
> >
> > Thanks, this works for me.
> >
> > I think it's fine to use the "dev" releases with GnuTLS too. Debian and
> > Fedora both use them.
> 
> I can confirm that lynx 2.8.9dev.9 works properly with GnuTLS. Should we
> use the current stable release with OpenSSL or the development release
> with GnuTLS? And if we use the development release, should I submit the
> patches as a single version bump with the necessary small adjustments?

I would do it all in one: update to 2.8.9dev.9 and correct the configure
flags so it works correctly. I think that "update" and "make the updated
version work correctly" belong in the same commit since one change
doesn't make sense without the other.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-10-09 19:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-07  0:48 [PATCH] gnu: lynx: Fix GnuTLS support Kei Kebreau
2016-10-07  1:28 ` Leo Famulari
2016-10-07  1:56   ` Tobias Geerinckx-Rice
2016-10-07  2:02     ` Tobias Geerinckx-Rice
2016-10-07  6:27       ` ng0
2016-10-07 14:42   ` Kei Kebreau
2016-10-08 13:58     ` ng0
2016-10-08 16:22       ` Kei Kebreau
2016-10-08 21:47     ` Leo Famulari
2016-10-09 17:55       ` Kei Kebreau
2016-10-09 19:20         ` Leo Famulari [this message]
2016-10-09 20:16           ` Kei Kebreau
2016-10-09 20:36             ` Leo Famulari
2016-10-09 21:00               ` Kei Kebreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161009192019.GB3025@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=kei@openmailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).