unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: ng0 <ngillmann@runbox.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] mailmanclient
Date: Wed, 28 Sep 2016 13:48:50 -0400	[thread overview]
Message-ID: <20160928174850.GB14001@jasmine> (raw)
In-Reply-To: <87d1joaqcf.fsf@we.make.ritual.n0.is>

On Wed, Sep 28, 2016 at 05:25:52PM +0000, ng0 wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > [ Unknown signature status ]
> > On Wed, Sep 28, 2016 at 05:02:56PM +0000, ng0 wrote:
> >> Subject: [PATCH] gnu: Add python-mailmanclient.
> >> 
> >> * gnu/packages/mail.scm (python-mailmanclient): New variable.
> >
> >> +(define-public python2-mailmanclient
> >> +  (let ((base (package-with-python2
> >> +               (strip-python2-variant python-mailmanclient))))
> >> +    (package (inherit base)
> >> +      (native-inputs
> >> +       `(("python2-setuptools" ,python2-setuptools))))))
> >
> > This variant will not be used unless there is a python2-variant
> > properties field in python-mailman, like this:
> >
> > (properties `((python2-variant . ,(delay python2-mailmanclient))))
> >
> > You can see the recent commit "gnu: Add python-q. (e8c9b01090)" for an
> > example in context.
> 
> Is this necessary for all python2 package variants? I rarely see this.

For any use of the python2-variant system, yes. I replied to a lot of
your submitted packages a couple days ago to point out that they needed
this change.

If you are just doing a plain package-with-python2 transformation, then
it's not required. Python2-variant is used when package-with-python2 is
not enough, because there are extra inputs, arguments, etc.

  reply	other threads:[~2016-09-28 17:49 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28 17:02 [PATCH] mailmanclient ng0
2016-09-28 17:11 ` ng0
2016-09-28 17:14 ` Leo Famulari
2016-09-28 17:25   ` ng0
2016-09-28 17:48     ` Leo Famulari [this message]
2016-09-28 18:24       ` Hartmut Goebel
2016-09-28 17:37   ` Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160928174850.GB14001@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=ngillmann@runbox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).