From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] Add gctp
Date: Tue, 27 Sep 2016 13:38:08 -0400
Message-ID: <20160927173808.GF2497@jasmine>
References: <20160718214723.GA449@jasmine>
	<20160915.190808.526226800252619989.thomas.danckaert@gmail.com>
	<20160924010825.GA13078@jasmine>
	<20160924.214956.2240292588360339390.post@thomasdanckaert.be>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43905)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bowKl-0006uc-3v
	for guix-devel@gnu.org; Tue, 27 Sep 2016 13:38:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bowKg-0001se-Ug
	for guix-devel@gnu.org; Tue, 27 Sep 2016 13:38:22 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:56940)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bowKf-0001oT-OK
	for guix-devel@gnu.org; Tue, 27 Sep 2016 13:38:18 -0400
Content-Disposition: inline
In-Reply-To: <20160924.214956.2240292588360339390.post@thomasdanckaert.be>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Thomas Danckaert <post@thomasdanckaert.be>
Cc: guix-devel@gnu.org

On Sat, Sep 24, 2016 at 09:49:56PM +0200, Thomas Danckaert wrote:
> From: Leo Famulari <leo@famulari.name>
> Subject: Re: [PATCH] Add gctp
> Date: Fri, 23 Sep 2016 21:08:25 -0400
> 
> >> +    (version "2.0")
> >> +    (source
> >> +     (origin
> >> +       (method url-fetch)
> >> +       (uri "https://github.com/OkoSanto/GCTP/archive/v2.0.0.tar.gz")
> > 
> > The only thing I would like to change is this mismatch between the
> > version and the tarball name. Can we call it version 2.0.0?
> > 
> > Also, we should add a (file-name) field so that the downloaded tarball
> > has "gctp" in the name.
> > 
> > I can make these changes locally if you think they are okay.
> 
> Of course, go ahead!
> 
> Thanks for reviewing the patch(-es).

Great, pushed as 32f70e1f86141ed30f1026ea0cf8a4bd377004b0 !

> 
> Thomas