From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: [PATCH 4/6] gnu: linux-libre-beagle-bone-black: Remove kernel variant. Date: Mon, 26 Sep 2016 18:49:34 +0200 Message-ID: <20160926164934.GA25011@jocasta.intra> References: <20160926103447.31830-1-david@craven.ch> <20160926103447.31830-4-david@craven.ch> <20160926132344.GA23258@jocasta.intra> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="envbJBWh7q8WU6mo" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39485) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boZ6A-0006Iz-GB for guix-devel@gnu.org; Mon, 26 Sep 2016 12:49:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boZ66-00050q-1W for guix-devel@gnu.org; Mon, 26 Sep 2016 12:49:45 -0400 Received: from de.cellform.com ([88.217.224.109]:56828 helo=jocasta.intra) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boZ65-00050i-Oe for guix-devel@gnu.org; Mon, 26 Sep 2016 12:49:41 -0400 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Vincent Legoll Cc: guix-devel --envbJBWh7q8WU6mo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 26, 2016 at 04:24:10PM +0200, Vincent Legoll wrote: Hello, =20 @David: the following question is nothing against you, I just took the opportunity to ask, sorry for the thread hijacking. =20 On Mon, Sep 26, 2016 at 3:23 PM, John Darrington wrote: > Why are we removing this? =20 Is it just me finding this changelog format usefulness to be very low ? =20 I entirely agree. =20 Our current convention for commit messages is aesthetically pleasing, but useless. It is redundant to put in the message WHAT has changed. That can be easily determined by running "git show". What is much more usefull is the reason WHY we changed it. Recently, on another project, I came across a line of code which I was pretty sure was pointless. I was about to delete it - but I=20 decided to check first. So I ran "git blame" to find out which=20 commit had added it. Then I ran git show to get the full details of that commit. Fortunately, the person who had committed it 5 years ago had mentioned exactly why it was needed. - and it was there for a very valid reason too. Had we been using the Guix convention, this would probably have been deleted and consequences would have followed. I vote that we make the reason for a commit to be compulsory. All other details optional. J' --=20 Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --envbJBWh7q8WU6mo Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlfpUZ4ACgkQimdxnC3oJ7PcowCgikqAwnuMXxbsGfLsiSKbk5sV mYoAniErVeoGNz/FERvK2XvTS2FgJ2zV =644M -----END PGP SIGNATURE----- --envbJBWh7q8WU6mo--