From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: Re: [PATCH 5/6] gnu: make-u-boot-package: Add files-to-install
	argument.
Date: Mon, 26 Sep 2016 14:39:26 +0200
Message-ID: <20160926143926.14eccdc3@scratchpost.org>
References: <20160926103447.31830-1-david@craven.ch>
	<20160926103447.31830-5-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59152)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1boVC5-0004bL-4V
	for guix-devel@gnu.org; Mon, 26 Sep 2016 08:39:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1boVBz-0006AL-1t
	for guix-devel@gnu.org; Mon, 26 Sep 2016 08:39:36 -0400
Received: from dd1012.kasserver.com ([85.13.128.8]:39812)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1boVBy-0006AF-RM
	for guix-devel@gnu.org; Mon, 26 Sep 2016 08:39:30 -0400
In-Reply-To: <20160926103447.31830-5-david@craven.ch>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

Hi David,

On Mon, 26 Sep 2016 12:34:46 +0200
David Craven <david@craven.ch> wrote:

>  (define-public u-boot-vexpress
> -  (make-u-boot-package "vexpress_ca9x4" "arm-linux-gnueabihf"))
> +  (make-u-boot-package "vexpress_ca9x4" "arm-linux-gnueabihf" '("u-boot.bin")))
>  
>  (define-public u-boot-malta
> -  (make-u-boot-package "malta" "mips64el-linux-gnuabi64"))
> +  (make-u-boot-package "malta" "mips64el-linux-gnuabi64" '("u-boot.bin")))
>  
>  (define-public u-boot-beagle-bone-black
> -  (make-u-boot-package "am335x_boneblack" "arm-linux-gnueabihf"))
> +  (make-u-boot-package "am335x_boneblack" "arm-linux-gnueabihf" '("MLO" "u-boot.img")))
                                                                   ^^^^
Ughh... are we sure we want to do that? I don't think a regular user would know what to put there. If the U-Boot build is from a clean slate it's not like there are stray files lying around or anything - we can just copy them all if we want.

Also, I don't think that we will have these define-public things for different systems in the long run. I posted a generated patch adding *all* of the supported U-Boot systems and Ludo vetoed it (and I agree by now - it's not necessary).

My preferred approach would be to allow the user to put the following into /etc/config.scm :

(bootloader (u-boot-configuration
              (device "/dev/mmcblk0")
              (package (make-u-boot-package "malta")))

(Nothing was left off)

What do you think?