From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: Re: [Patch 5/10] opendht: Propagate argon2.
Date: Mon, 26 Sep 2016 01:24:19 +0200
Message-ID: <20160926012419.601feaf2@scratchpost.org>
References: <87mvjc1quq.fsf@openmailbox.org> <87y42wzg8n.fsf@openmailbox.org>
	<87ponrpp3n.fsf@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38641)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1boImb-0002xi-Vi
	for guix-devel@gnu.org; Sun, 25 Sep 2016 19:24:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1boImW-0000nn-Vz
	for guix-devel@gnu.org; Sun, 25 Sep 2016 19:24:29 -0400
Received: from dd1012.kasserver.com ([85.13.128.8]:50024)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1boImW-0000nj-Pg
	for guix-devel@gnu.org; Sun, 25 Sep 2016 19:24:24 -0400
In-Reply-To: <87ponrpp3n.fsf@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Lukas Gradl <lgradl@openmailbox.org>
Cc: guix-devel@gnu.org

Hi Lukas,

On Sun, 25 Sep 2016 17:54:36 -0500
Lukas Gradl <lgradl@openmailbox.org> wrote:

> I noticed that some linker flags are set incorrectly.  The result was
> that the output of
> "objdump -p /gnu/store/...-opendht-0.6.1/lib/libopendht.so"
> was missing a 'NEEDED' line for 'libargon2.so.0'.
> The attached patch fixes that.

I'd also add a comment that the purpose of all that is to unbundle argon2 and then re-add the installed argon2 library.

Looks good to me.