From: Leo Famulari <leo@famulari.name>
To: guix-devel@gnu.org
Subject: Re: Expat regression fix for master branch
Date: Sun, 25 Sep 2016 19:18:11 -0400 [thread overview]
Message-ID: <20160925231811.GA1722@jasmine> (raw)
In-Reply-To: <20160912213515.GA15911@jasmine>
[-- Attachment #1: Type: text/plain, Size: 648 bytes --]
On Mon, Sep 12, 2016 at 05:35:15PM -0400, Leo Famulari wrote:
> This patch applies an upstream patch for a regression caused by the fix
> for CVE-2016-0718.
>
> Apparently, the bug only manifests when building with -DXML_UNICODE,
> which I don't think our package does.
Sebastian Pipping (the Expat maintainer) contacted me to recommend that
we apply the patch on the master branch.
He says that the faulty code path can be reached even when XML_UNICODE
is not defined. Apparently, building with -DXML_UNICODE merely makes it
easier to reach the faulty code.
I think we should take Sebastian's advice. What does everyone think?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-09-25 23:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 21:35 Expat regression fix for master branch Leo Famulari
2016-09-13 21:54 ` Ludovic Courtès
2016-09-14 18:14 ` Leo Famulari
2016-09-25 23:18 ` Leo Famulari [this message]
2016-09-26 8:21 ` Efraim Flashner
2016-09-27 17:50 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160925231811.GA1722@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).