From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 03/11] gnu: Add python-flask-babel.
Date: Sun, 25 Sep 2016 14:05:00 -0400
Message-ID: <20160925180500.GC10837@jasmine>
References: <20160913013827.25877-1-ng0@we.make.ritual.n0.is>
	<20160913013827.25877-3-ng0@we.make.ritual.n0.is>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38873)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1boDnf-0004Oa-Mo
	for guix-devel@gnu.org; Sun, 25 Sep 2016 14:05:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1boDna-0002jT-Ml
	for guix-devel@gnu.org; Sun, 25 Sep 2016 14:05:15 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:47011)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1boDnZ-0002eV-GW
	for guix-devel@gnu.org; Sun, 25 Sep 2016 14:05:10 -0400
Content-Disposition: inline
In-Reply-To: <20160913013827.25877-3-ng0@we.make.ritual.n0.is>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: ng0 <ng0@we.make.ritual.n0.is>
Cc: guix-devel@gnu.org

On Tue, Sep 13, 2016 at 01:38:19AM +0000, ng0 wrote:
> * gnu/packages/python.scm (python-flask-babel): New variable.
> +(define-public python2-flask-babel
> +  (package
> +    (inherit (package-with-python2
> +              (strip-python2-variant python-flask-babel)))
> +    (native-inputs
> +     `(("python2-setuptools" ,python2-setuptools)))
> +    (inputs
> +     `(("python2-flask" ,python2-flask)
> +       ("python2-babel" ,python2-babel)
> +       ("python2-jinja2" ,python2-jinja2)
> +       ("python2-pytz" ,python2-pytz)))))

This won't work without the correct (properties) field in
python-flask-babel. Also, this (inputs) field could append to the
inherited inputs.

I mentioned an example in a review I did a few minutes ago.