From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] Add tinycm. Date: Sun, 25 Sep 2016 13:38:55 -0400 Message-ID: <20160925173855.GC9499@jasmine> References: <87shstv4lh.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UFHRwCdBEJvubb2X" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:33595) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boDOS-0005J5-8y for guix-devel@gnu.org; Sun, 25 Sep 2016 13:39:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1boDOM-000201-It for guix-devel@gnu.org; Sun, 25 Sep 2016 13:39:11 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:36522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1boDOK-0001ue-QV for guix-devel@gnu.org; Sun, 25 Sep 2016 13:39:06 -0400 Content-Disposition: inline In-Reply-To: <87shstv4lh.fsf@we.make.ritual.n0.is> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org --UFHRwCdBEJvubb2X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 21, 2016 at 12:07:22PM +0000, ng0 wrote: > This adds tinycm. But now that I am finished, I think this is not what I > wanted, I wanted http://tinycm.slitaz.org/ . I assumed without looking > at the source that this is just a fork. > Well, no damage in more packages I'd say. Thanks for this patch series! >=20 > Subject: [PATCH 1/8] gnu: Add python-boolexp. >=20 > * gnu/packages/python.scm (python-boolexp): New variable. > +(define-public python2-boolexp > + (let ((boolexp (package-with-python2 python-boolexp))) > + (package (inherit boolexp) > + (native-inputs > + `(("python2-setuptools" ,python2-setuptools)))))) This won't work in all cases. You have to use the python2-variant system when python-2 versions of packages have different inputs from the python-3 version. Can you update the patch? See commit bd74be7b8c6f3df34d8556f55ab9ef7411c07933 for an example. Some more of the patches have this issue. I won't mention it again as I remove them. > Subject: [PATCH 3/8] gnu: Add python2-ruamel.ordereddict >=20 > * gnu/packages/python.scm (python2-ruamel.ordereddict): New variable. > + ;; XXX: https://bitbucket.org/ruamel/ordereddict/issues/2 > + (arguments > + `(#:python ,python-2)) Please add a line to the comment that says something like "Only Python 2 is supported", so that the hyperlink has some context. > Subject: [PATCH 4/8] gnu: Add python-distro. >=20 > * gnu/packages/python.scm (python-distro): New variable. `guix lint` should suggest some changes to the synopsis and description. > Subject: [PATCH 5/8] mailmap: Add new address for ng0. LGTM but I have no experience with this subject. > Subject: [PATCH 6/8] gnu: Add python-typing. >=20 > * gnu/packages/python.scm (python-typing): New variable. LGTM > Subject: [PATCH 7/8] gnu: Add python-ruamel.yaml. >=20 > * gnu/packages/python.scm (python-ruamel.yaml): New variable. > + (arguments > + `(;; Otherwise it complains that you have to do "pypi install ." > + #:configure-flags (list "--single-version-externally-managed" > + "--record=3Druamel.yaml.txt"))) Is the '--record' line also described by the comment about "pypi install"? If not please add a comment that explains it. > + (inputs > + `(("python-typing" ,python-typing))) > +(define-public python2-ruamel.yaml > + (package (inherit (package-with-python2 > + (strip-python2-variant python-ruamel.yaml))) > + (name "python2-ruamel.yaml") > + (inputs > + `(("python2-ruamel.ordereddict" ,python2-ruamel.ordereddict) > + ("python2-typing" ,python2-typing))) > + (native-inputs > + `(("python2-setuptools" ,python2-setuptools))))) You'll need to add a (properties) field to ensure that the python2-variant is used. Also, you don't have to specify python2-typing; you can append to the inherited inputs that are transformed by package-with-python2. See 0adc21c2933fbe47ee37d90acdb4ad8cbc60ed69 for an example. --UFHRwCdBEJvubb2X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX6AuvAAoJECZG+jC6yn8IFVwP/1vXMJmL0MXpvxvJBKpjGlgc UILI/aof6nyxTxlO3hNPEaojzflO1g7n5HLN54LMNBl79A5ZSVvndFTX6sc/d86V eNY8f6Gor4b3JO+sMOZ1B1K0LgN0PsLVB8CEpTlRavpbq72F9SIOJSVeDJjj+nEC 0xd4df5wjQ9IX9fMzNLfZpXQ9PO7pOcevW6ao1ZplKVNK2WyplYa0PtCb5gqOHZg FkcYnJjh/jYU/bIRejB3sUN+moIsFOMsINw7JuYdbslAYJcyc3s0cDKwE7fnHjWr +P97IsFpVZ4C40gFabOM37E9v4nGmE2hn+9QfxYbb7ry2N7RKNop0Cypsbp8Hci8 cdP19EQyn3kPJOh1J/tWJBt9zBolGVRpdtC+P5TyizSXA/6KI+PXWcR5LqClkzdZ YNxieon4ghAvIkI9yM85Evr7ymkhjkw7c8GKogQAAFfT11022A5VTQhBoKYad2ID techJVntO0DFhz3S7jsZtuf10oITGrWlU7JhKVpDZUxKAieZaMMTFvkO4b6vUiRc oscMj+YNn21HAPgi14D/XG0G/iBKh7YR4wRnRMYP23qKrZld9h8CwhKVd3A4e8sv xfap0KaX/xKfJdTtcVr7mhV0DrsVh+bvxZd4NOHE0OPweOqZBN6AdiCyT+QdXsYI wKvGCRn9jCkNpJJPZCAj =oJab -----END PGP SIGNATURE----- --UFHRwCdBEJvubb2X--