Re: [PATCH] gnu: Add epic5.

[Leo Famulari <leo@famulari.name>]

[-- Attachment #1: Type: text/plain, Size: 2106 bytes --]

On Sat, Sep 24, 2016 at 01:04:47PM +0000, ng0 wrote:
> I tried to get ssl working via:
> - patching include/config.h
> - just export the variable which was in include/config.h without
>   patching it.
> 
> but it seems like epic5 does something different which 'justworks™' in
> ircii. epic5 is based on ircii.
> If ssl is mandatory, I'll check their git repository and see if there
> have been any commits recently fixing this.

In general, SSL / TLS support is not mandatory for packages that do
network traffic. But, users should not be misled into thinking that they
are using TLS when it doesn't work.

So, what happens when you use this epic5 to connect to an IRC server
that uses TLS?

Does it fail silently? That's not okay.

> Subject: [PATCH 1/2] licenses: Add epic.
> 
> * guix/licenses.scm (epic): New variable.

Does anything else use this license? If not, I would leave it out and
use non-copyleft for the epic5 package license.

> Subject: [PATCH 2/2] gnu: Add epic5.
> 
> * gnu/packages/irc.scm (epic5): New variable.

> +         (add-after 'unpack 'patch-bsdinstall
> +           ;; We should include this in the build-system, bsdinstall is a standard.
> +           ;; If we just remove /bin/ some part of the bsdinstall breaks.
> +           (lambda _
> +             (substitute* "bsdinstall"
> +               (("/bin/strip") "strip")
> +               (("/bin/cp") "cp")
> +               (("/bin/chmod") "chmod")
> +               (("/etc/chown") "chown")
> +               (("/bin/chgrp") "chgrp")
> +               (("/bin/mkdir") "mkdir")
> +               (("/bin/rm") "rm")
> +               (("/bin/mv") "mv")
> +               (("/etc/") ""))))

"/etc/" is not an executable path. Do we need to substitute it here?
What happens when you don't change that line?

> +               (zero?
> +                (system* "./configure"
> +                         (string-append "--prefix=" out)
> +                         "--with-ipv6" "--with-libarchive"

What does it use libarchive for? What happens if we leave it out?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]