From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: Cosmetical change: remove inconsistent "$file ends here"? Date: Sun, 25 Sep 2016 11:32:04 +0200 Message-ID: <20160925093203.GA2317@jocasta.intra> References: <871t09t6f1.fsf@we.make.ritual.n0.is> <87a8ewl6tq.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cNdxnHkX5QqsyA0e" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bo5nC-000385-HU for guix-devel@gnu.org; Sun, 25 Sep 2016 05:32:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bo5n7-0004Rp-5O for guix-devel@gnu.org; Sun, 25 Sep 2016 05:32:13 -0400 Received: from de.cellform.com ([88.217.224.109]:56757 helo=jocasta.intra) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bo5n6-0004Rj-Nz for guix-devel@gnu.org; Sun, 25 Sep 2016 05:32:09 -0400 Content-Disposition: inline In-Reply-To: <87a8ewl6tq.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Alex Kost Cc: guix-devel@gnu.org --cNdxnHkX5QqsyA0e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 25, 2016 at 11:30:41AM +0300, Alex Kost wrote: ng0 (2016-09-24 20:00 +0000) wrote: =20 > We should either be consistent with this in all files or remove this > altogether in my opinion. > >> ng0@shadowwalker ~/src/guix/guix-no-changes$ egrep -nr "ends here" >> gnu/build/vm.scm:323:;;; vm.scm ends here ... > What do you think? =20 I don't know what the original purpose of this convention is, it was probably invented in those ancient times when dinosaurs walked by streets, but I kinda like these "ends here" things :-) =20 The only purpose I see in using them: you can be sure that there will not appear redundant newlines (introduced by untidy commits) in the end of files. =20 Anyway, I vote for leaving them and adding the missing ones. =20 I have a better idea. Let's remove these verbose messages, and write an AP= I, which is capable of opening and streaming files , we could call those funct= ions -=20 for example - "fopen" and "fread". But here comes the clever bit: We al= so provide a function - let's call it "feof". This approach will have the advantage that we could use this API to write t= hings called "editors" which might display some user friendly string such as "End= of buffer"=20 when the end is encountered. Once these tools are developed, we could inform the community that they no = longer need to put the string "file ends here" at the end of their files. WDYT ? --=20 Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --cNdxnHkX5QqsyA0e Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlfnmZMACgkQimdxnC3oJ7Pd2wCcDSYgSXYhi2gsGa4NchQ/EiNH mo8AnicdIxNmDYQIBIDYtthdX2DGQkbT =aGYt -----END PGP SIGNATURE----- --cNdxnHkX5QqsyA0e--