From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] Add gctp Date: Fri, 23 Sep 2016 21:08:25 -0400 Message-ID: <20160924010825.GA13078@jasmine> References: <20160701203312.GA27184@jasmine> <20160707.094018.564247646166673024.post@thomasdanckaert.be> <20160718214723.GA449@jasmine> <20160915.190808.526226800252619989.thomas.danckaert@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnbSK-0004Wa-4A for guix-devel@gnu.org; Fri, 23 Sep 2016 21:08:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bnbSF-0003W4-S5 for guix-devel@gnu.org; Fri, 23 Sep 2016 21:08:39 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:33158) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bnbSE-0003SZ-Is for guix-devel@gnu.org; Fri, 23 Sep 2016 21:08:35 -0400 Content-Disposition: inline In-Reply-To: <20160915.190808.526226800252619989.thomas.danckaert@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Thomas Danckaert Cc: guix-devel@gnu.org On Thu, Sep 15, 2016 at 07:08:08PM +0200, Thomas Danckaert wrote: > Hi Guix, > > I've cleaned up my gctp patch, following your advice: > > From: Leo Famulari > Subject: Re: [PATCH] Add gctp > Date: Mon, 18 Jul 2016 17:47:23 -0400 > > > If it's not possible to use the bundled GCTPs then we have to use an > > external library, but I think it should be maintained outside of Guix. > > As you say, it should not be much work to put it on a public Git repo or > > to host a tarball, since the development is basically complete. > > I took the contents of the gctpc20.tar.Z archive distributed with wgrib2, > added an autoconf-based build script, and published the repository on > Github. Changes are minor: I had to make some changes to the test programs, > and fix one input routine (int size mismatch when reading an auxiliary > binary file). > > This version of the patch uses a release tarball published on github. Is > there a better place I can host a tarball (if not the repository itself?). Wow, thank you! A GitHub tarball is fine if it works (and this one does). > + (version "2.0") > + (source > + (origin > + (method url-fetch) > + (uri "https://github.com/OkoSanto/GCTP/archive/v2.0.0.tar.gz") The only thing I would like to change is this mismatch between the version and the tarball name. Can we call it version 2.0.0? Also, we should add a (file-name) field so that the downloaded tarball has "gctp" in the name. I can make these changes locally if you think they are okay.