From: Leo Famulari <leo@famulari.name>
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: guix-devel@gnu.org
Subject: Re: Definite article in synopsis
Date: Fri, 23 Sep 2016 01:10:17 -0400 [thread overview]
Message-ID: <20160923051017.GA17132@jasmine> (raw)
In-Reply-To: <6d27b754-5fa2-1fda-8d0a-431ef224b7ef@uq.edu.au>
On Fri, Sep 23, 2016 at 10:32:56AM +1000, Ben Woodcroft wrote:
> On 09/23/2016 10:15 AM, Leo Famulari wrote:
> > On Wed, Sep 21, 2016 at 12:59:51PM +0200, John Darrington wrote:
> > > I thought we had a policy that the synopsis field must not
> > > start with an article.
> > >
> > > However running
> > > grep 'synopsis *"The' *.scm
> > >
> > > shows that we have many instances where this policy is
> > > not followed.
> > >
> > > Or have I misunderstood something?
> > It's a minor issue. I think that making many small changes throughout
> > the master branch will be too disruptive for what is a relatively minor
> > style issue.
> This is true even though changing a description doesn't trigger a rebuild?
I figured that there were hundreds of instances, but checking for "A"
and "An" (what `guix lint` checks for), it's only 8 packages. So I don't
think this change will be disruptive.
My comment about the change being "disruptive" was not about rebuilding
but rather code "churn". And non-functional code churn does seem worth
the human time required to merge hundreds of conflicts.
Is there a reason to remove "The"? I think it would not always be an
improvement, for example in a case like this:
(synopsis "The Erlang programming language")
> > If the change is made, I'd prefer it on core-updates. Merging master
> > into core-updates and vice versa already requires somebody to resolve a
> > lot of merge conflicts. I'd rather not add to that burden.
> Do you have any recommendations for changing our practices to ease this
> issue?
One idea is to do big widespread non-functional changes between
core-updates branches. That is, immediately after a release is tagged,
before a new core-updates branch is required.
next prev parent reply other threads:[~2016-09-23 5:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 10:59 Definite article in synopsis John Darrington
2016-09-23 0:15 ` Leo Famulari
2016-09-23 0:32 ` Ben Woodcroft
2016-09-23 5:10 ` Leo Famulari [this message]
2016-09-24 2:28 ` Ludovic Courtès
2016-09-24 2:53 ` Leo Famulari
2016-09-23 4:53 ` John Darrington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923051017.GA17132@jasmine \
--to=leo@famulari.name \
--cc=b.woodcroft@uq.edu.au \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).