From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: python-build-system: Allow build flags
Date: Thu, 22 Sep 2016 11:26:02 +0200
Message-ID: <20160922112602.3193360b@scratchpost.org>
References: <20160215084046.62d5307a@scratchpost.org>
	<20160523041319.GA10803@jasmine> <20160707002228.GA16818@jasmine>
	<20160707063120.GB17506@debian-netbook>
	<20160708005116.GA8415@jasmine>
	<20160922102754.75e436f8@scratchpost.org>
	<20160922104528.4e8801a9@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38777)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1bn0Gh-0003VG-QR
	for guix-devel@gnu.org; Thu, 22 Sep 2016 05:26:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1bn0Ge-0004Bm-58
	for guix-devel@gnu.org; Thu, 22 Sep 2016 05:26:10 -0400
Received: from dd1012.kasserver.com ([85.13.128.8]:45249)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1bn0Gd-0004Bc-Ue
	for guix-devel@gnu.org; Thu, 22 Sep 2016 05:26:08 -0400
In-Reply-To: <20160922104528.4e8801a9@scratchpost.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org

> I just checked - the python-build-system doesn't allow passing flags when invoking setup.py . That's the only reason the custom build phase is there...

We could adapt python-build-system like that:

diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
index 9109fb4..6304f0c 100644
--- a/guix/build/python-build-system.scm
+++ b/guix/build/python-build-system.scm
@@ -44,9 +44,9 @@
          (zero? (apply system* "python" "setup.py" command params)))
       (error "no setup.py found")))
 
-(define* (build #:rest empty)
+(define* (build #:key (build-flags '()) #:allow-other-keys)
   "Build a given Python package."
-  (call-setuppy "build" '()))
+  (call-setuppy "build" build-flags))
 
 (define* (check #:key tests? test-target #:allow-other-keys)
   "Run the test suite of a given Python package."

How can I check which rebuilds that would cause? Seems to rebuild quite a bit on my local machine when I try to install python2-wxpython now.