From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Patterson Subject: Re: [PATCH 1/2] gnu: Add sqlcipher. Date: Tue, 20 Sep 2016 19:09:11 -0400 Message-ID: <20160920190911.5fe1c694@uwaterloo.ca> References: <20160914193014.24224-1-ajpatter@uwaterloo.ca> <20160914193014.24224-2-ajpatter@uwaterloo.ca> <20160920084244.GA17906@macbook42.flashner.co.il> <20160920214950.GB7018@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmUiJ-000791-0M for guix-devel@gnu.org; Tue, 20 Sep 2016 19:44:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmUiE-0002IR-Pn for guix-devel@gnu.org; Tue, 20 Sep 2016 19:44:33 -0400 Received: from mailservices.uwaterloo.ca ([129.97.128.141]:34308 helo=mailchk-m05.uwaterloo.ca) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmUiE-0002IN-IL for guix-devel@gnu.org; Tue, 20 Sep 2016 19:44:30 -0400 In-Reply-To: <20160920214950.GB7018@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org On Tue, 20 Sep 2016 17:49:50 -0400 Leo Famulari wrote: > On Tue, Sep 20, 2016 at 11:42:44AM +0300, Efraim Flashner wrote: > > On Wed, Sep 14, 2016 at 03:30:13PM -0400, Andy Patterson wrote: =20 > > > + ;; tests are un-maintained in this fork > > > + #:tests? #f)) > > > + (home-page "https://www.zetetic.net/sqlcipher/") > > > + (synopsis > > > + "Library providing transparent encryption of SQLite > > > database files") > > > + (description "SQLCipher is an SQLite extension that provides > > > transparent +256-bit AES encryption of database files. Pages are > > > encrypted before being +written to disk and are decrypted when > > > read back. It=E2=80=99s well suited for +protecting embedded applica= tion > > > databases and for mobile development.") > > > + (license license:bsd-3))) > > > --=20 > > > 2.10.0 > > > =20 > >=20 > > I'm a little confused how much of this is actually upstream sqlite > > and how much is their own code. The commit messages look like > > they're continually merging in sqlite. Also, many of the files in > > the src folder I checked are public-domain and not bsd-3 licensed. =20 >=20 > I'm also wondering what the relationship is between this project and > SQLite. The comment about disabling tests describes SQLCipher as a > fork, but the SQLCipher home page describe it as an extension. I'd say it's a fork based on the source structure and commit history as Efraim mentioned. I think the upstream describes it as an extension because it adds extra behaviour on top of SQLite while maintaining API compatibility, rather than changing its fundamental behaviour. I could alter the description (I've currently just used the upstream's wording) in order to reflect the fact that this isn't an SQLite "loadable extension". Do you have any reccomendations along those lines? Thanks, -- Andy