From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivan Vilata i Balaguer Subject: Re: [PATCH 2/2] gnu: python: Add i3-quickswitch. Date: Tue, 20 Sep 2016 09:30:27 +0200 Message-ID: <20160920073027.GB29433@sax.terramar.selidor.net> References: <20160919214218.GD10174@jasmine> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47246) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmFVk-0000Sy-18 for guix-devel@gnu.org; Tue, 20 Sep 2016 03:30:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bmFVg-0001iH-5i for guix-devel@gnu.org; Tue, 20 Sep 2016 03:30:35 -0400 Received: from lev.selidor.net ([2600:3c03:e001:1100::1]:47130) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bmFVg-0001gz-15 for guix-devel@gnu.org; Tue, 20 Sep 2016 03:30:32 -0400 Content-Disposition: inline In-Reply-To: <20160919214218.GD10174@jasmine> <20160919213937.GB10174@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org, Ivan Vilata i Balaguer Leo Famulari (2016-09-19 17:39:37 -0400) wrote: > On Mon, Sep 19, 2016 at 11:24:02AM +0200, Ivan Vilata i Balaguer wrote: > > Thanks Leo and Brendan for your comments, I'm writing new versions > > of the packages following your suggestions, unfortunately I found > > out that ``quickswitch.py`` makes use of the Debian-specific > > ``which`` tool, so I'm also working on including a small patch > > (which I've also [reported][1] for completeness). More things to > > learn!`;)` > > `which` is not a Debian tool, and we do sometimes have to add it as an > input to packages. Our package name is 'which'. It might be enough to > just add the 'which' package to quickswitch-for-i3's inputs (or > native-inputs, if `which` is only used while building). > > www.gnu.org/software/which/ Oh my, I missed the actual ``which`` package, sorry! Anyway it's only used to check that ``dmenu`` is there, and the function that does the check is pretty broken anyway, causing other errors (see [my PR][1]). However I found a [simpler PR][2] that fixes all the errors and also does away with the dependency on ``which``, so I closed my PR and will use the latter. [1]: https://github.com/proxypoke/quickswitch-for-i3/pull/28 [2]: https://github.com/proxypoke/quickswitch-for-i3/pull/24 Leo Famulari (2016-09-19 17:42:18 -0400) wrote: > On Mon, Sep 19, 2016 at 08:20:26PM +1000, Brendan Tildesley wrote: > > I'm not a fan of "quickswitch-for-i3" and "python-i3-py". Perhaps a > > better solution is to ensure "i3-py" in the description or synopsis > > so that `guix package -s' finds it. As for quickswitch, isn't the > > upstream name also simply "quickswitch-i3"? > > Our packaging guidelines say that we should use the "project name chosen > upstream" [0], which in this case appears to be quickswitch-for-i3 [1]. The PyPi package, the ``setup(name=...)`` argument in ``setup.py`` and the content of the readme use ``quickswitch-i3`` as the project short name, while the GitHub URL and readme title use "quickswitch for i3" as a more descriptive name. In this case I consider the former name to be the "official" short name, also compatible with ``pip`` and others. Is there any other similar case already in Guix? > And python-i3-py does follow our conventions for naming Python modules > [2]. > > [0] > https://www.gnu.org/software/guix/manual/html_node/Package-Naming.html > > [1] > https://github.com/proxypoke/quickswitch-for-i3 > > [2] > https://www.gnu.org/software/guix/manual/html_node/Python-Modules.html So I can do a third iteration with the PR#24 patch and package names ``python-i3-py`` and ``quickswitch-i3``. What do you think? One more time, thanks for your help and comments! -- Ivan Vilata i Balaguer -- https://elvil.net/