From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ivan Vilata i Balaguer <ivan@selidor.net>
Subject: Re: [PATCH 2/2] gnu: python: Add i3-quickswitch.
Date: Mon, 19 Sep 2016 11:24:02 +0200
Message-ID: <20160919092402.GB6601@sax.terramar.selidor.net>
References: <20160914091229.GA14555@sax.terramar.selidor.net>
	<20160914091724.GG5711@sax.terramar.selidor.net>
	<20160916054637.GB14289@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39289)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ivan@selidor.net>) id 1bluo7-0007lF-K4
	for guix-devel@gnu.org; Mon, 19 Sep 2016 05:24:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ivan@selidor.net>) id 1bluo3-0001Rh-F2
	for guix-devel@gnu.org; Mon, 19 Sep 2016 05:24:10 -0400
Received: from lev.selidor.net ([66.246.138.156]:51335)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ivan@selidor.net>) id 1bluo3-0001Qz-Ad
	for guix-devel@gnu.org; Mon, 19 Sep 2016 05:24:07 -0400
Content-Disposition: inline
In-Reply-To: <20160916054637.GB14289@jasmine>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: guix-devel@gnu.org

Leo Famulari (2016-09-16 01:46:37 -0400) wrote:

> On Wed, Sep 14, 2016 at 11:17:24AM +0200, Ivan Vilata i Balaguer wrote:
> > Subject: [PATCH 2/2] gnu: python: Add i3-quickswitch.
> > 
> > * gnu/packages/python.scm (i3-quickswitch): New variable.
> 
> Cool, this works :)
> 
> > +(define-public i3-quickswitch
> > +  (package
> > +    (name "i3-quickswitch")
> 
> Again, I think that we should stay closer to the upstream name, in this
> case "quickswitch-for-i3".
> 
> > +    (build-system python-build-system)
> 
> Also again, it would be nice to include README.rst.

Thanks Leo and Brendan for your comments, I'm writing new versions of
the packages following your suggestions, unfortunately I found out that
``quickswitch.py`` makes use of the Debian-specific ``which`` tool, so
I'm also working on including a small patch (which I've also
[reported][1] for completeness).  More things to learn!`;)`

[1]: https://github.com/proxypoke/quickswitch-for-i3/pull/28

-- 
Ivan Vilata i Balaguer -- https://elvil.net/