unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: ng0 <ng0@we.make.ritual.n0.is>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 1/2] gnu: Add femtolisp.
Date: Tue, 13 Sep 2016 15:40:32 -0400	[thread overview]
Message-ID: <20160913194032.GA9226@jasmine> (raw)
In-Reply-To: <20160912135756.7185-1-ng0@we.make.ritual.n0.is>

On Mon, Sep 12, 2016 at 01:57:55PM +0000, ng0 wrote:
> * gnu/packages/lisp.scm (femtolisp): New variable.

Thanks! Pushed with the following minor changes:

> +  (let* ((commit "68c5b1225572ecf2c52baf62f928063e5a30511b")
> +        (revision "1"))

I made it use (let) instead of (let*). The difference is described here:
https://www.gnu.org/software/guile/manual/html_node/Local-Bindings.html#index-let

> +      (version (string-append "0.0.0-" revision "-" (string-take commit 7)))
                                                    ^
I used a '.' instead of a '-', to conform with the guidelines:
https://www.gnu.org/software/guix/manual/html_node/Version-Numbers.html

  parent reply	other threads:[~2016-09-13 19:40 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12 13:57 [PATCH 1/2] gnu: Add femtolisp ng0
2016-09-12 13:57 ` [PATCH 2/2] gnu: lispf4: Remove unused inputs key ng0
2016-09-13 19:00   ` Leo Famulari
2016-09-13 19:21     ` ng0
2016-09-13 19:40 ` Leo Famulari [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-09-13 19:04 [PATCH 1/2] gnu: Add femtolisp ng0
2016-09-13 19:30 ` Ricardo Wurmus
2016-09-13 19:45   ` ng0
2016-09-13 20:32   ` ng0
2016-09-14  9:00     ` Ricardo Wurmus
2016-09-14  9:31       ` ng0
2016-09-14  9:48         ` ng0
2016-09-14 10:03           ` Ricardo Wurmus
2016-09-14 10:15             ` ng0
2016-09-14 11:05               ` Ricardo Wurmus
2016-09-14 11:17                 ` ng0
2016-09-14 12:03                   ` ng0
2016-09-18 10:02                     ` Andreas Enge
2016-09-20  6:14                       ` Ludovic Courtès
2016-09-21 10:37                         ` ng0
2016-09-21 15:33                           ` Ludovic Courtès
2016-09-21 19:30                             ` Ricardo Wurmus
2016-09-18 12:20                     ` ng0
2016-09-18 12:25                     ` ng0

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160913194032.GA9226@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=ng0@we.make.ritual.n0.is \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).