From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add qscintilla. Date: Tue, 13 Sep 2016 13:05:29 -0400 Message-ID: <20160913170529.GD20731@jasmine> References: <87a8fddnyi.fsf@openmailbox.org> <87r38ndfwb.fsf@openmailbox.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Nq2Wo0NMKNjxTN9z" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjr9d-0006kY-1w for guix-devel@gnu.org; Tue, 13 Sep 2016 13:05:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjr9X-0005cb-8W for guix-devel@gnu.org; Tue, 13 Sep 2016 13:05:52 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:45790) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjr9U-0005Ru-PD for guix-devel@gnu.org; Tue, 13 Sep 2016 13:05:47 -0400 Content-Disposition: inline In-Reply-To: <87r38ndfwb.fsf@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Kei Kebreau Cc: guix-devel@gnu.org --Nq2Wo0NMKNjxTN9z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Sep 13, 2016 at 10:37:56AM -0400, Kei Kebreau wrote: > Kei Kebreau writes: > > A component necessary for GNU Octave's GUI. > > How does it look? > Not sure how packaging Qt packages goes, but I've discovered that > GNU Octave's GUI only builds with Qt4 support. I've changed the patch to > adjust this. Should I leave the old patch as is and add a qt4 package > that inherits from it? Since Qt 4 is no longer supported upstream, we are trying to remove users of the qt-4 package so that we can eventually remove the qt-4 package itself. With that in mind, how about a qscintilla-for-octave package? This package can inherit from a qscintilla that uses qtbase, and I think it should be declared privately [using (define) instead of (define-public]. > + (replace 'configure > + (lambda _ > + (chdir "Qt4Qt5") > + (zero? (system* "qmake" "qscintilla.pro")))) I would change directory in a separate 'chdir' phase. > + (substitute* (find-files "." "Makefile") > + (((string-append "INSTALL_ROOT)" qt)) > + (string-append "INSTALL_ROOT)" out))))))))) ^ Inconsistent indentation. Also, this phase should return #t, since the return value of substitute* is unspecified. > + (synopsis "Qt5 port of the Scintilla editing component") Make sure to adjust the Qt name as appropriate :) --Nq2Wo0NMKNjxTN9z Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX2DHWAAoJECZG+jC6yn8IT7oP/1Kpk+znRhuLU5znmZ5/n2lU G5nJgAEBrU3fzWbGBniCXlyXKyhtfxzQDGDPaNB2hBVACwdjkwWd4guA+0p3Xu7j q/NznES6acvfeNOJZFGmjUem/xmYStWm5rAPblFeWRuKd9FuK67hHxNvrsaId2u1 w7+CS97DrR8lnSJfvGWva5Q00FxZwb/0JjM/ulWknJOipGrs4XdgiImHO7gw3q4S S/z4nU5lA/Ir3KBwHi+zxhh+uxV79Da6HjqnmfC+0mcEp6Dd3MA8REonsTdGaVJZ 51oI1aIIyOmd79fJ1bhGSv7nZJ0DcPWy7/yuJGDKd1eL3A1O4YkiZ5AQcEk83M35 P3a+Con/KIZMBUIm/VM5LaKDPeSSNNBXWIvocpgETPLx8h6FaPN8dpkiL71AwjcP W5ot72xVS4mwdyl1qKvseYq1dzSNAL5RsItTqUs+eFdPrtQarzBrZnSrPo3cTAwz 8hAPJy5RradoqgCAf0n74qI4D6to3/IDo+I9QqblPwCkgYMA8BXYEYv+RAPMALtj kufiDFIGKnw/fdAMx31QbxR0adLUQ9Y1C2q0IpUWZaluJIBw7wfkXA4q4jH2rkGu S+hCDJhdWR0MhFpgXYLkzsucGJhgnHgh0SmtsDngHhzcswd3ePfDkp282OT8lo0R XV3CbVySzHa9iXq6MTQA =j96l -----END PGP SIGNATURE----- --Nq2Wo0NMKNjxTN9z--