From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add python-gunicorn and python2-gunicorn.
Date: Tue, 13 Sep 2016 11:51:33 -0400
Message-ID: <20160913155133.GC13516@jasmine>
References: <1473627035-12350-1-git-send-email-h.goebel@crazy-compilers.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34838)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bjpzz-0004KV-Jv
	for guix-devel@gnu.org; Tue, 13 Sep 2016 11:51:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bjpzv-0007xR-D5
	for guix-devel@gnu.org; Tue, 13 Sep 2016 11:51:50 -0400
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:36861)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bjpzt-0007kr-4D
	for guix-devel@gnu.org; Tue, 13 Sep 2016 11:51:47 -0400
Content-Disposition: inline
In-Reply-To: <1473627035-12350-1-git-send-email-h.goebel@crazy-compilers.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org

On Sun, Sep 11, 2016 at 10:50:35PM +0200, Hartmut Goebel wrote:
> * gnu/packages/web.scm (python-gunicorn, python2-gunicorn): New
>   variables.

Thanks for this! Regarding the naming question, I think it's fine to
call it 'gunicorn'. Prefixing with 'python-' is more appropriate for
libraries and other "helper" packages, whereas user facing or standalone
applications can use the plain upstream name, in my opinion.

See the manual, section 7.6.5 Python Modules, for a little bit of
guidance.

> +         (add-before 'check 'remove-requirements
> +           ; setup.py reads test-requirements from a file which is
> +           ; pinning to other versions then guix provides. This also
> +           ; enforces optional packages like pytst-cov. So clean the
> +           ; list.
> +           (lambda _
> +             (substitute* "requirements_test.txt"
> +               ((".*") "")))))))
> +    (native-inputs
> +     `(("python-pytest" ,python-pytest)
> +       ;("python-pytest-cov" ,python-pytest-cov) ; optional

I think we should either use pytest-cov or remove this commented line.
What do you think?

> +(define-public python2-gunicorn
> +  (let ((base (package-with-python2
> +               (strip-python2-variant python-gunicorn))))
> +    ; Note: byte-compiling gunicorn/workers/_gaiohttp.py with Python 2
> +    ; fails, but this module will be available for Python 3 only
> +    ; anyway.

Can you elaborate on this? Does python2-gunicorn still work? If so,
okay.