From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: Add microcom
Date: Tue, 13 Sep 2016 11:36:17 -0400
Message-ID: <20160913153617.GA13516@jasmine>
References: <1473613018-22728-1-git-send-email-jmd@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59196)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bjplO-0002AZ-Lb
	for guix-devel@gnu.org; Tue, 13 Sep 2016 11:36:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bjplJ-0004L0-KA
	for guix-devel@gnu.org; Tue, 13 Sep 2016 11:36:45 -0400
Content-Disposition: inline
In-Reply-To: <1473613018-22728-1-git-send-email-jmd@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: John Darrington <jmd@gnu.org>
Cc: guix-devel@gnu.org

On Sun, Sep 11, 2016 at 06:56:58PM +0200, John Darrington wrote:
> * gnu/packages/microcom.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

> +    (version "2016.01.09")

I think we should use the upstream tag, "v2016.01.0".

> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "git://git.pengutronix.de/git/tools/microcom.git")
> +                    (commit "caf3687611ca855b4fa80c2a9a2fbb020834fc4e")))

Then, you can use the tag name as the commit. The tag I mentioned is
equivalent to this commit.

> +    (license gpl2+)))

My interpretation of the first paragraph of COPYING [0] is that the
package is licensed under the GPL version 2 only. What do you think?

[0]
http://git.pengutronix.de/?p=tools/microcom.git;a=blob;f=COPYING