Re: [PATCH] gnu: par2cmdline.

[Eric Bavier <ericbavier@openmailbox.org>]

Hi!  Thanks for the patch; a few comments below:

On Mon, 12 Sep 2016 19:18:42 +1000
Brendan Tildesley <brendan.tildesley@openmailbox.org> wrote:

> From 0bb6fe510ce6a6c1cd0851527909db16b167d703 Mon Sep 17 00:00:00 2001
> From: Brendan Tildesley <brendan.tildesley@openmailbox.org>
> Date: Mon, 12 Sep 2016 16:02:27 +1000
> Subject: [PATCH] gnu: Add par2cmdline.
> 
> * gnu/package/disk.scm (par2cmdline): New variable.
[...]
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/Parchive/par2cmdline/archive/v"
> +                                  version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "0ykfb7ar0x0flfdgf6i8xphyv5b93dalbjj2jb6hx7sdjax33n1g"))
> +              ;; This test merely needs a file to test recovery on, but
> +              ;; /dev/random is essentially /dev/urandom plus minimum entropy
> +              ;; locking, making the test hang indefinitely. This change is
> +              ;; already upstream: remove on upgrade to future 0.6.15.

Could you possobily list the upstream commit id for this change?

> +              (modules '((guix build utils)))
> +              (snippet
> +               '(substitute* "tests/test20" (("if=/dev/random") "if=/dev/urandom")))))
> +    (native-inputs
> +     `(("automake" ,automake)
> +       ("autoconf" ,autoconf)))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'aclocal
> +           (lambda _ (zero? (system* "aclocal"))))
> +         (add-after 'aclocal 'automake
> +           (lambda _ (zero? (system* "automake" "--add-missing"))))
> +         (add-after 'automake 'autoconf
> +           (lambda _ (zero? (system* "autoconf")))))))

Could these phases be squashed into a single phase that calls
"autoreconf"?

> +    (synopsis "File verification and repair tool")
> +    (description "Par2cmdline is a tool for generating RAID-like PAR2 recovery
> +files a fraction the size their of using Reed-Solomon coding.  PAR2 files can
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I think that bit could be left out.  Unless fixing a typo could make it
understandable.

> +be stored along side backup or published files for recovering from bitrot.")
> +    (home-page "https://github.com/Parchive/par2cmdline")
> +    (license (list license:gpl2+  ; *

We can leave gpl2+ out, since in this case it is covered by gpl3+

> +                   license:gpl3+  ; config.guess
> +                   license:x11)))); install-sh

Could you send an updated patch?
Thanks,
`~Eric