From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH 03/16] gnu: Add python-promise. Date: Mon, 12 Sep 2016 08:31:24 +0300 Message-ID: <20160912053123.GL6073@macbook42.flashner.co.il> References: <20160911185857.2123-1-efraim@flashner.co.il> <20160911185857.2123-4-efraim@flashner.co.il> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="uwB7x3tnyrZQfZJI" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjJqK-0004u4-Ty for guix-devel@gnu.org; Mon, 12 Sep 2016 01:31:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjJqG-0004zL-PD for guix-devel@gnu.org; Mon, 12 Sep 2016 01:31:44 -0400 Received: from flashner.co.il ([178.62.234.194]:34727) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjJqG-0004w1-HU for guix-devel@gnu.org; Mon, 12 Sep 2016 01:31:40 -0400 Content-Disposition: inline In-Reply-To: List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: David Craven Cc: guix-devel --uwB7x3tnyrZQfZJI Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 11, 2016 at 09:41:10PM +0200, David Craven wrote: > > +(define-public python2-promise > > + (let ((promise (package-with-python2 > > + (strip-python2-variant python-promise)))) > > + (package (inherit promise) > > + (arguments (substitute-keyword-arguments (package-arguments prom= ise) > > + ((#:tests? _) #t))) >=20 > I've seen this in a few of your patches. Why do tests fail with python > but not with python-2? In this one the tests require python-futures, which is python2 only. I tried adding python2-futures anyway to the native-inputs but unsuprisingly it didn't help with the tests. The right fix is to have upstream change it so that it says (something like) tests: require: "pytest" ,(version < '3' "futures"); but I need to read up more on my python syntax to suggest a patch. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --uwB7x3tnyrZQfZJI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJX1j2WAAoJEPTB05F+rO6TU+4P/1ltcx293ayNC88a7lJH+ADP v0CCcmutL+YvjRdMUS073I/FOp03xkLcy2ap3si7n1MZHWLoMh7LXfzJ//7L/Woa tp6gsub77J6H/co6YcghIpK8UJCD5CpUuQ6NVBQCCC0EQVJteUHP7CTL0MYnj0h3 rtxTt566OLsq/dkGGPBLL23MuykWxqArBFd4kqp8umZxqccEFO7fwVodTcd4sAQp 3sSpB+gceb+rLxcLwV/9XUhD0zAyUyWrM597inKT/BySOTA1AwndQ9OaUhIJ0ZmO WibytT0gkyBxFVzOlhbw0CP2vhoAl0LJBxN7X7nSxft+nlFoY9AMFWG/C1iY9i8K xDhMD9KyEe3uquoYptQmFgsEg2pHQBfC6lOj2cQZaEnWafKs65Zck5Y1QiRJbb0U M/5Zw8dHZe0a5QRra07dkhxWTMwYPoL69l2WJVY491TNdOtfoXg1SekTAwC3PbLF Nc5R6S1zwRAurwHW7iUtjPnAQZ9xBNbY1JnFsRCGaa/QtIQTqQpEAA4uWpG6yusY pscnJx9vvo+8qNXfprQ+gKKl3NKYyG0RgAbdEvmNIQGSATA1UVm234W4//SIPb/P Zc2uQnFR+AqGaC92ebOqrz1GVt//akuQju0viBNLSE3Q5L20Hflhi1sl83iwGEzH Hm6Rn6Rt4/f0p0x+Pfih =I7VE -----END PGP SIGNATURE----- --uwB7x3tnyrZQfZJI--