unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add sslh.
Date: Sun, 11 Sep 2016 23:23:03 -0400	[thread overview]
Message-ID: <20160912032303.GA16878@jasmine> (raw)
In-Reply-To: <1473640328-28092-1-git-send-email-me@tobias.gr>

On Mon, Sep 12, 2016 at 02:32:08AM +0200, Tobias Geerinckx-Rice wrote:
> * gnu/packages/networking.scm (sslh): New variable.

Interesting package!

> +         ;; Many of these files are mentioned in the man page. Install them.
> +         (add-after 'install 'install-documentation
> +                    (lambda* (#:key outputs #:allow-other-keys)
> +                      (let* ((out (assoc-ref outputs "out"))
> +                             (doc (string-append out "/share/doc")))
> +                        (install-file "README.md" doc)
> +                        (for-each
> +                         (lambda (file)
> +                           (install-file file (string-append doc "/examples")))
> +                         (append (find-files "." "\\.cfg")
> +                                 (find-files "scripts" ".*"))))

Rather than '/share/doc', I think the doc variable should use
'/share/doc/sslh'. Otherwise, when installed into a profile, the
examples will be in '~/.guix-profile/share/doc'. It would be better if
they were in '~/.guix-profile/share/doc/sslh'.

  reply	other threads:[~2016-09-12  3:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12  0:32 [PATCH] gnu: Add sslh Tobias Geerinckx-Rice
2016-09-12  3:23 ` Leo Famulari [this message]
2016-09-12  4:20   ` Tobias Geerinckx-Rice
2016-09-12 10:03 ` Efraim Flashner
2016-09-12 12:33   ` Tobias Geerinckx-Rice
2016-09-12 13:52     ` Efraim Flashner
2016-09-12 21:14     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160912032303.GA16878@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).