From: Leo Famulari <leo@famulari.name>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add darkhttpd.
Date: Fri, 9 Sep 2016 16:41:58 -0400 [thread overview]
Message-ID: <20160909204158.GA4337@jasmine> (raw)
In-Reply-To: <20160909195623.12889-1-arunisaac@systemreboot.net>
On Sat, Sep 10, 2016 at 01:26:23AM +0530, Arun Isaac wrote:
> * gnu/packages/web.scm (darkhttpd): New variable.
Hi, thank you for this patch!
> + `(#:tests? #f
When we disable the tests, we have to leave a comment explaining why. It
can be as simple as "No test suite" if that is the case.
> + (replace 'configure
> + (lambda _ (setenv "CC" "gcc")))
This has the effect of setting the CC variable and skipping any other
'configure' actions. Is this intended? If there is no './configure'
script or similar tool, this environment variable could be set in
#:make-flags or in a 'setenv' phase.
> + (replace 'install
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let ((bin (string-append (assoc-ref outputs "out") "/bin")))
> + (mkdir-p bin)
> + (copy-file "darkhttpd" (string-append bin "/darkhttpd"))))))))
mkdir-p and copy-file and be replaced with install-file.
> + (description "darkhttpd is a simple static web server. It is
> +standalone and does not need inetd or ucspi-tcp. It does not need any
> +config files -- you only have to specify the www root.")
You can make an 'em dash' in Texinfo like this:
"...config files---you only..."
> + (home-page "https://unix4lyfe.org/darkhttpd/")
> + (license l:bsd-2)))
The license on the main source file is the ISC license:
https://unix4lyfe.org/gitweb/darkhttpd/blob/HEAD:/darkhttpd.c
Can you send an updated patch?
next prev parent reply other threads:[~2016-09-09 20:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 19:56 [PATCH] gnu: Add darkhttpd Arun Isaac
2016-09-09 20:41 ` Leo Famulari [this message]
2016-09-10 5:19 ` Arun Isaac
2016-09-10 6:51 ` Arun Isaac
2016-09-10 7:10 ` Alex Kost
2016-09-10 12:30 ` Arun Isaac
2016-09-10 17:44 ` Alex Kost
2016-09-11 15:14 ` Arun Isaac
2016-09-11 19:20 ` Arun Isaac
2016-09-13 15:42 ` Leo Famulari
2016-09-13 17:09 ` Arun Isaac
2016-09-14 6:01 ` Arun Isaac
2016-09-14 21:28 ` Leo Famulari
2016-09-15 6:17 ` Arun Isaac
2016-09-15 15:23 ` Leo Famulari
2016-09-11 13:52 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160909204158.GA4337@jasmine \
--to=leo@famulari.name \
--cc=arunisaac@systemreboot.net \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).