From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH][v2] gnu: Add perl-curses Date: Wed, 7 Sep 2016 09:09:05 +0300 Message-ID: <20160907060905.GJ28032@macbook42.flashner.co.il> References: <20160615012316.GA21204@khazad-dum> <87d1m4sdbh.fsf@we.make.ritual.n0.is> <20160724052518.GA4905@debian-netbook> <8760regh14.fsf@we.make.ritual.n0.is> <871t1k51uj.fsf@we.make.ritual.n0.is> <87k2fcev8k.fsf@we.make.ritual.n0.is> <20160906173600.GD28032@macbook42.flashner.co.il> <87k2eo3dz4.fsf@we.make.ritual.n0.is> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="djJN5oi3zFpblwUd" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhW2w-0002e5-DB for guix-devel@gnu.org; Wed, 07 Sep 2016 02:09:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhW2t-00027P-4b for guix-devel@gnu.org; Wed, 07 Sep 2016 02:09:18 -0400 Received: from flashner.co.il ([178.62.234.194]:56976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhW2s-00026w-Oe for guix-devel@gnu.org; Wed, 07 Sep 2016 02:09:15 -0400 Content-Disposition: inline In-Reply-To: <87k2eo3dz4.fsf@we.make.ritual.n0.is> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org --djJN5oi3zFpblwUd Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 06, 2016 at 09:39:11PM +0000, ng0 wrote: > Hi, >=20 > Efraim Flashner writes: >=20 > > [ Unknown signature status ] > > On Fri, Aug 19, 2016 at 01:36:27PM +0000, ng0 wrote: > >> Okay, when I build this without "FORMS" it succeeds. Works for me. > >>=20 > > > >> From a72020974650298e89b82abda8e07f722f7cf32c Mon Sep 17 00:00:00 2001 > >> From: ng0 > >> Date: Fri, 19 Aug 2016 13:13:42 +0000 > >> Subject: [PATCH 1/2] gnu: Add perl-curses. >=20 > =E2=80=A6 >=20 > >> --=20 > >> 2.9.3 > >>=20 > > > > I think this would go better in ncurses.scm than in perl. Can you send > > an updated patch? Thanks. >=20 > =E2=80=A6 >=20 > Thanks for reviewing. >=20 > Okay, updated patch appended. I have worked on this without sending an > update for a while, I had something already fixed in my secushare > packaging repository. >=20 > From 618b04248f4db327a8fd72c5bd626a4f80c6ccf8 Mon Sep 17 00:00:00 2001 > From: ng0 > Date: Sat, 23 Jul 2016 13:03:22 +0000 > Subject: [PATCH] gnu: Add perl-curses. >=20 > * gnu/packages/ncurses.scm (perl-curses): New variable. > --- > gnu/packages/ncurses.scm | 47 ++++++++++++++++++++++++++++++++++++++++++= ++++- > 1 file changed, 46 insertions(+), 1 deletion(-) >=20 > diff --git a/gnu/packages/ncurses.scm b/gnu/packages/ncurses.scm > index 147033a..1c46355 100644 > --- a/gnu/packages/ncurses.scm > +++ b/gnu/packages/ncurses.scm > @@ -2,6 +2,7 @@ > ;;; Copyright =C2=A9 2012, 2013, 2014, 2015 Ludovic Court=C3=A8s > ;;; Copyright =C2=A9 2014 Mark H Weaver > ;;; Copyright =C2=A9 2015 Leo Famulari > +;;; Copyright =C2=A9 2016 ng0 > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -22,7 +23,10 @@ > #:use-module (guix licenses) > #:use-module (guix packages) > #:use-module (guix download) > - #:use-module (guix build-system gnu)) > + #:use-module (guix build-system gnu) > + #:use-module (guix build-system perl) > + #:use-module (gnu packages) > + #:use-module (gnu packages perl)) > =20 > (define-public ncurses > (let ((patch-makefile-phase > @@ -161,3 +165,44 @@ curses widgets, such as dialog boxes.") > (home-page "http://invisible-island.net/dialog/dialog.html") > ;; Includes the gpl3 file "config.sub" from Automake. > (license (list lgpl2.1 gpl3)))) > + > +(define-public perl-curses > + (package > + (name "perl-curses") > + (version "1.36") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "mirror://cpan/authors/id/G/GI/GIRAFFED/" > + "Curses-" version ".tar.gz")) > + (sha256 > + (base32 > + "0r6xd9wr0c25rr28zixhqipak575zqsfb7r7f2693i9il1dpj554")))) > + (build-system perl-build-system) > + (inputs > + `(("ncurses" ,ncurses))) > + (arguments > + `(#:make-maker-flags (list "PANELS" "MENUS") > + #:phases > + (modify-phases %standard-phases > + (add-before > + 'configure 'set-curses-ldflags > + (lambda* (#:key inputs #:allow-other-keys) > + (let* ((ncurses (assoc-ref inputs "ncurses")) > + (include (string-append ncurses "/include")) > + (lib (string-append ncurses "/lib"))) > + (setenv "CURSES_LIBTYPE" "ncurses") > + (setenv "CURSES_CFLAGS" (string-append "-I" include)) > + (setenv "CURSES_PANEL_CFLAGS" (string-append "-I" include= )) > + (setenv "CURSES_MENU_CFLAGS" (string-append "-I" include)) > + (setenv "CURSES_FORM_CFLAGS" (string-append "-I" include)) > + (setenv "CURSES_LDFLAGS" (string-append "-L" lib " -lncur= ses")) > + (setenv "CURSES_PANEL_LDFLAGS" (string-append "-L" lib " = -lpanel")) > + (setenv "CURSES_MENU_LDFLAGS" (string-append "-L" lib " -= lmenu")) > + (setenv "CURSES_FORM_LDFLAGS" (string-append "-L" lib " -= lform")))))))) > + (home-page "http://search.cpan.org/dist/Curses") > + (synopsis "Terminal screen handling and optimization") > + (description > + "@code{Curses} is the interface between Perl and the curses library > +of your system.") > + (license (package-license perl)))) > --=20 > 2.10.0 >=20 I added a #t at the end of all the setenv-s and fixed the indentation on 'configure. Patch pushed! --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --djJN5oi3zFpblwUd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJXz68AAAoJEPTB05F+rO6TPH0P/iVXmHnyZnmhvDPJCDJeOC/7 o2H+aaGeQhGEvzeOLencAyWxsHpoHlclawNy6fJabJg+U/tAZv+WeG2h4dkn22OJ i202oOZ+/b/wSHPfZGoLKr/hqj701zcdz/X0EhDrBANRrWN/tsWxxY1d9h+gSKDE cOBw/KdP+ExNrrhdrHyy4hPRrh4ZjX+UaFpipjSmvltNQL474UKyzds8vzZvnMJ+ FDgSA3tYW2Rn5F7FU3RRkPOBOxX+BhyAqbUPdx7piJwrpP2fOT5sWmUssIdan/tf iszCKhfznbK+W6RG4LJJtc+vOL8vv1v+qOIR2eYi/Xe+TdD/QblwPtnIu1QZ3AA5 oX5CQhpCNBDlndLd4KfeeRLyI1uu6pRihCPdsoQSzGPp0vQII9LUfLYrfeI6BeFZ MpYHi0qKmIjSp3nHboEg9ym53KVqV7KBGR6UF9EHDT8UxHDPWvj/yjlT87yJstH4 LLMWUPHJGV3LarJPMa7KPggVEAFnT08EiM8Y6dt3Wj9VWTMiXV+X5br8PXti3psb cykpmxuSIT7C+jR0xGb1XpOGT/q/xtbfSkRDHlxE0rHytf2mtciqv8NksatN56Jk IBh88PV0AB8yhQlOvdQkBpBpXjbDYxKXc4hYrNPGZNO2Ho3Z0LglF3fbxiPj44Az uzp8ZI+RoQTo0opM+Mq4 =0Onz -----END PGP SIGNATURE----- --djJN5oi3zFpblwUd--