From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH] gnu: Add gzstream. Date: Tue, 6 Sep 2016 22:27:03 +0300 Message-ID: <20160906192703.GH28032@macbook42.flashner.co.il> References: <87eg56yvdh.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> <20160830134846.328552cd@openmailbox.org> <878tvdyu8o.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="9ToWwKEyhugL+MAz" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48607) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhOIo-00011r-Ow for guix-devel@gnu.org; Tue, 06 Sep 2016 17:53:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bhOIl-000484-K1 for guix-devel@gnu.org; Tue, 06 Sep 2016 17:53:10 -0400 Received: from flashner.co.il ([178.62.234.194]:55064) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bhOIl-00047i-8u for guix-devel@gnu.org; Tue, 06 Sep 2016 17:53:07 -0400 Content-Disposition: inline In-Reply-To: <878tvdyu8o.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org --9ToWwKEyhugL+MAz Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 31, 2016 at 01:53:59PM +0100, Marius Bakke wrote: > Eric Bavier writes: >=20 > > Thanks for the patch! Comments below: > > > > On Tue, 30 Aug 2016 19:17:14 +0100 > > Marius Bakke wrote: > > > >> From 5e96b895c1ed77a6bfdcbe5c6dbd68220fd5a8dc Mon Sep 17 00:00:00 2001 > >> From: Marius Bakke > >> Date: Fri, 12 Aug 2016 02:29:51 +0100 > >> Subject: [PATCH 1/1] gnu: Add gzstream. > >>=20 > >> * gnu/packages/compression.scm (gzstream): New variable. > >> --- > >> [...] > >> + (source (origin > >> + (method url-fetch) > >> + (uri > >> + ;; No versioned URL, but last release was in 2003. > >> + "http://www.cs.unc.edu/Research/compgeom/gzstream/gzst= ream.tgz") > >> + (file-name (string-append name "-" version ".tar.gz")) > >> + (sha256 > >> + (base32 > >> + "00y19pqjsdj5zcrx4p9j56pl73vayfwnb7y2hvp423nx0cwv5b4r= ")))) > > > > There's a gzstream.o file in the tarball. Could you remove it an origin > > snippet? > > > >> [...] > >> + (home-page "http://www.cs.unc.edu/Research/compgeom/gzstream/") > >> + (synopsis "C++ library that provides the functionality of zlib in= a C++ iostream") > > > > Maybe: "Compressed C++ iostream" > > > >> + (description "gzstream is a small library for providing zlib func= tionality in a C++ > >> +iostream. It is basically just a wrapper.") > > > > The second sentence may be left off, IMO. > > > >> + (license license:lgpl2.1))) > > ^ > > This should be lgpl2.1+ because of the "or later" in the file headers. > > > > Could you send an updated patch? >=20 > Hi Eric, >=20 > Thanks for the quick feedback! Correct on all accounts. >=20 > Updated patch below. >=20 > From a8aae7f44289c75f67f2bea1046206f79acbdbdb Mon Sep 17 00:00:00 2001 > From: Marius Bakke > Date: Fri, 12 Aug 2016 02:29:51 +0100 > Subject: [PATCH] gnu: Add gzstream. >=20 > * gnu/packages/compression.scm (gzstream): New variable. > --- > gnu/packages/compression.scm | 39 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) >=20 > diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm > index c239d16..3f60c5b 100644 > --- a/gnu/packages/compression.scm > +++ b/gnu/packages/compression.scm > @@ -12,6 +12,7 @@ > ;;; Copyright =C2=A9 2016 Danny Milosavljevic > ;;; Copyright =C2=A9 2016 Tobias Geerinckx-Rice > ;;; Copyright =C2=A9 2016 David Craven > +;;; Copyright =C2=A9 2016 Marius Bakke > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -895,3 +896,41 @@ compared to the fastest mode of zlib, Snappy is an o= rder of magnitude faster > for most inputs, but the resulting compressed files are anywhere from 20= % to > 100% bigger.") > (license license:asl2.0))) > + > +(define-public gzstream > + (package > + (name "gzstream") > + (version "1.5") > + (source (origin > + (method url-fetch) > + (uri > + ;; No versioned URL, but last release was in 2003. > + "http://www.cs.unc.edu/Research/compgeom/gzstream/gzstrea= m.tgz") > + (file-name (string-append name "-" version ".tar.gz")) > + (sha256 > + (base32 > + "00y19pqjsdj5zcrx4p9j56pl73vayfwnb7y2hvp423nx0cwv5b4r")) > + (modules '((guix build utils))) > + (snippet > + ;; Remove pre-compiled object. > + '(delete-file "gzstream.o")))) > + (build-system gnu-build-system) > + (arguments > + `(#:test-target "test" > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (lib (string-append out "/lib")) > + (include (string-append out "/include"))) > + (install-file "libgzstream.a" lib) > + (install-file "gzstream.h" include) > + #t)))))) > + (propagated-inputs `(("zlib" ,zlib))) > + (home-page "http://www.cs.unc.edu/Research/compgeom/gzstream/") > + (synopsis "Compressed C++ iostream") > + (description "gzstream is a small library for providing zlib > +functionality in a C++ iostream.") > + (license license:lgpl2.1+))) > --=20 > 2.9.3 >=20 Patch pushed! --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --9ToWwKEyhugL+MAz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJXzxiHAAoJEPTB05F+rO6TAn8P/1tct9jzISvvwiUEUkRB+KOt 7XfisldkMy6eQ36P9FG57Rpv9tg04UxVvoHICzFC2LIgiuzmQFMEP9UgT5l9DF4N 0/aAPzQyJrtbok8tLzHGM8Mk4rSzWTzKxyolxQXxmOvDN4tDNAAP4eUyQfhG/cL/ 8HGOSxMwCj4IifMKmyzy+wH9HmzIBokdDh9Q6AKeE1W5qm4nGVucoxNyoHQ5Yo89 H2M3AcZyWG0Jnr+dKu8FUf4EdFtUZ9joOnp88VsyNOkTr2ancCvuyhu2yKmF751d 2dvCjJWx6pY/VzW9SnxtqfDpmYeZ72B0KW1Y7rC/Ncu6z4+d74OFRGOlSNB8CMpS nEBoCd+KWgqWOc8sNwqXxU1gcLLcp7A2A3OfTW2vGw+c7ISXVzJ6KhozD7YWzGad B6WLeRugB2WHLQ4nEkeFRN7+HaXquIJCe51xDRhZy9pfHCJinQtD9Sika22C/35+ tXSSgdWPLTKNOysy/0youKa6XwAIFLkUZcepmijSW1A2ugTN3EbGjPImFafOJORp NrGxCL8ok7bk/OriRQ7puVkryIn56GCAFJ8TMpeU15ZXHfv8cCUyTbIdbaNQ9Uoc P0kN+fkn/UAkiynhOtmJuBATt5WMfPl1PFpwL4tyR3UljUVTgz8wRPdFiop12g/L QLPSJzXHfaFI7Y8BInms =prOF -----END PGP SIGNATURE----- --9ToWwKEyhugL+MAz--