unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: 02/11: activation: Allow home directories to be created under /var/lib.
       [not found] ` <20160906155317.D019622017C@vcs.savannah.gnu.org>
@ 2016-09-06 18:48   ` Leo Famulari
  2016-09-06 20:04     ` David Craven
  0 siblings, 1 reply; 3+ messages in thread
From: Leo Famulari @ 2016-09-06 18:48 UTC (permalink / raw)
  To: guix-devel

On Tue, Sep 06, 2016 at 03:53:17PM +0000, David Craven wrote:
> commit 6526d43ea4fb0cd151a0d5e9a072c651c1c963d1
> Author: David Craven <david@craven.ch>
> Date:   Fri Aug 26 21:45:57 2016 +0200
> 
>     activation: Allow home directories to be created under /var/lib.
>     
>     * gnu/build/activation.scm (activate-user+groups): Make sure /var/lib
>       exists.
> ---
>  gnu/build/activation.scm |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/gnu/build/activation.scm b/gnu/build/activation.scm
> index 10aa58d..7dc40b0 100644
> --- a/gnu/build/activation.scm
> +++ b/gnu/build/activation.scm
> @@ -233,6 +233,9 @@ numeric gid or #f."
>    ;; 'groupadd' aborts if the file doesn't already exist.
>    (touch "/etc/group")
>  
> +  ;; Allow home directories to be created under /var/lib.
> +  (mkdir "/var/lib")
> +
>    ;; Create the root account so we can use 'useradd' and 'groupadd'.
>    (activate-user (find (match-lambda
>                          ((name (? zero?) _ ...) #t)
> 

This would fail when /var/lib already existed. I fixed it by using
mkdir-p in a7199b7d994433eaabb989690887b921d053d761.

Yesterday was my first time using the system tests:
https://www.gnu.org/software/guix/manual/html_node/Running-the-Test-Suite.html#Running-the-Test-Suite

I assume they would have caught this, but I'm not sure. They definitely
would have caught my breakage of GRUB when I updated QEMU recently ;)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: 02/11: activation: Allow home directories to be created under /var/lib.
  2016-09-06 18:48   ` 02/11: activation: Allow home directories to be created under /var/lib Leo Famulari
@ 2016-09-06 20:04     ` David Craven
  2016-09-07 12:18       ` Ludovic Courtès
  0 siblings, 1 reply; 3+ messages in thread
From: David Craven @ 2016-09-06 20:04 UTC (permalink / raw)
  To: Leo Famulari; +Cc: guix-devel

>> +  (mkdir-p "/var/lib")

>‘mkdir’ should be enough.

I initially used mkdir-p...

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: 02/11: activation: Allow home directories to be created under /var/lib.
  2016-09-06 20:04     ` David Craven
@ 2016-09-07 12:18       ` Ludovic Courtès
  0 siblings, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2016-09-07 12:18 UTC (permalink / raw)
  To: David Craven; +Cc: guix-devel

David Craven <david@craven.ch> skribis:

>>> +  (mkdir-p "/var/lib")
>
>>‘mkdir’ should be enough.
>
> I initially used mkdir-p...

My bad, sorry!

Ludo’.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-09-07 12:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20160906155317.12854.59323@vcs.savannah.gnu.org>
     [not found] ` <20160906155317.D019622017C@vcs.savannah.gnu.org>
2016-09-06 18:48   ` 02/11: activation: Allow home directories to be created under /var/lib Leo Famulari
2016-09-06 20:04     ` David Craven
2016-09-07 12:18       ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).