From: Leo Famulari <leo@famulari.name>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 0/1] OpenSSL 1.1.0
Date: Tue, 6 Sep 2016 13:47:55 -0400 [thread overview]
Message-ID: <20160906174755.GA17204@jasmine> (raw)
In-Reply-To: <87shtdrz37.fsf@gnu.org>
On Tue, Sep 06, 2016 at 02:29:16PM +0200, Ludovic Courtès wrote:
> Leo Famulari <leo@famulari.name> skribis:
>
> > On Mon, Sep 05, 2016 at 10:35:09PM +0200, Ludovic Courtès wrote:
> >> Seems like most of the arguments and phases are shared with ‘openssl’,
> >> right? What about using ‘substitute-keyword-arguments’ to reduce
> >> duplication? Or are you concerned about potential breakage when one
> >> series or the other changes?
> >
> > I've attached an updated patch using 'substitute-keyword-arguments'.
> >
> > BTW, my previous patch made a one-line change to 'move-man3-pages',
> > deleting the leftover empty man3 directory in the main output after
> > copying the manpages to the 'doc' output. Is this change desired?
>
> Sure. Perhaps you can commit this part to core-updates?
Done!
> > From 83405a4ea3628cababd2ee5904c8d0628a002d05 Mon Sep 17 00:00:00 2001
> > From: Leo Famulari <leo@famulari.name>
> > Date: Fri, 2 Sep 2016 16:07:29 -0400
> > Subject: [PATCH] gnu: Add openssl-next.
> >
> > * gnu/packages/tls.scm (openssl-next): New variable.
> > * gnu/packages/patches/openssl-1.1.0-c-rehash-in.patch: New file.
> > * gnu/local.mk (dist_patch_DATA): Add it.
>
> LGTM, thank you!
Pushed! Thanks for the review :)
prev parent reply other threads:[~2016-09-06 17:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 1:59 [PATCH 0/1] OpenSSL 1.1.0 Leo Famulari
2016-09-02 1:59 ` [PATCH 1/1] gnu: openssl: Update to 1.1.0 Leo Famulari
2016-09-02 7:40 ` [PATCH 0/1] OpenSSL 1.1.0 Ricardo Wurmus
2016-09-02 12:43 ` Ludovic Courtès
2016-09-02 20:14 ` Leo Famulari
2016-09-02 20:30 ` Leo Famulari
2016-09-03 13:50 ` Ludovic Courtès
2016-09-03 14:06 ` Leo Famulari
2016-09-03 14:34 ` Ludovic Courtès
2016-09-04 2:20 ` Leo Famulari
2016-09-04 2:48 ` Leo Famulari
2016-09-05 20:35 ` Ludovic Courtès
2016-09-05 23:05 ` Leo Famulari
2016-09-06 12:29 ` Ludovic Courtès
2016-09-06 17:47 ` Leo Famulari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906174755.GA17204@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).