From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: Re: [PATCH 2/3] guix: ant-build-system: add empty `tests` target to default build.xml. Date: Mon, 5 Sep 2016 22:26:06 +0200 Message-ID: <20160905222606.139a8a6d@scratchpost.org> References: <1473067474-7485-1-git-send-email-h.goebel@crazy-compilers.com> <1473067474-7485-3-git-send-email-h.goebel@crazy-compilers.com> <57CD57DC.90005@crazy-compilers.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:43049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bh0T9-0000Nc-74 for guix-devel@gnu.org; Mon, 05 Sep 2016 16:26:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bh0T6-0001iT-0o for guix-devel@gnu.org; Mon, 05 Sep 2016 16:26:15 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:53060) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bh0T5-0001iM-QM for guix-devel@gnu.org; Mon, 05 Sep 2016 16:26:11 -0400 In-Reply-To: <57CD57DC.90005@crazy-compilers.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Hartmut Goebel Cc: guix-devel Hi Hartmut, On Mon, 5 Sep 2016 13:32:44 +0200 Hartmut Goebel wrote: > When specifying #:jar-file, the ant-builder will create a build.xml. > This build.xml did not include a test-target at all. So one *always* had > to include "#:tests? #f" to disable calling the (non-existing) > test-target - otherwise build would fail. But adding "#:tests? #f" is > just redundant. I see what you mean. But is it still possible to easily find out which packages have tests and which haven't after your patch? I think being able to know that is important since it's prudent to trust a package without tests (much) less. Also, would it be possible to auto-discover jUnit tests instead?