From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH] gnu: Add python-pypump Date: Mon, 5 Sep 2016 12:21:04 +0300 Message-ID: <20160905092104.GA23794@macbook42.flashner.co.il> References: <20160812183129.0f76b28a@openmailbox.org> <20160813125700.GA12089@jasmine> <20160813123242.6162b166@openmailbox.org> <20160813230714.GA22289@jasmine> <20160814160711.5c87d31e@openmailbox.org> <20160815184128.GA11573@jasmine> <20160815151757.51f21eed@openmailbox.org> <20160819221747.cpiu4g2l24qjmwtx@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tsOsTdHNUZQcU9Ye" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:59785) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgq5g-0004JI-J8 for guix-devel@gnu.org; Mon, 05 Sep 2016 05:21:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bgq5b-0005N3-Ew for guix-devel@gnu.org; Mon, 05 Sep 2016 05:21:19 -0400 Received: from flashner.co.il ([178.62.234.194]:57128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bgq5b-0005MD-3T for guix-devel@gnu.org; Mon, 05 Sep 2016 05:21:15 -0400 Content-Disposition: inline In-Reply-To: <20160819221747.cpiu4g2l24qjmwtx@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Leo Famulari Cc: guix-devel@gnu.org --tsOsTdHNUZQcU9Ye Content-Type: multipart/mixed; boundary="3MwIy2ne0vdjdPXF" Content-Disposition: inline --3MwIy2ne0vdjdPXF Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 19, 2016 at 06:17:47PM -0400, Leo Famulari wrote: > On Mon, Aug 15, 2016 at 03:17:57PM -0700, Dylan Jeffers wrote: > > On Mon, 15 Aug 2016 14:41:28 -0400 > > Leo Famulari wrote: > >=20 > > > On Sun, Aug 14, 2016 at 04:07:11PM -0700, Dylan Jeffers wrote: > > > > > The latest upstream version 0.7. Is there a reason not to use the > > > > > latest version in this case? =20 > > > >=20 > > > > For my immediate purposes, I need pypump 0.6, since thats the > > > > version used in my projects. Since the versions are quite > > > > different, maybe we include both of them? =20 > > >=20 > > > I think we should package the latest version, at least. > > >=20 > > > Maybe we could also package 0.6 with a package 'python-pypump-0.6' > > > that inherits from python-pypump. Or, you could keep that inherited > > > python-pypump-0.6 in a private package repo, and use > > > GUIX_PACKAGE_PATH. > > >=20 > > > I'd prefer the latter option. I don't think we have a precedent of > > > adding old releases, although we do sometimes keep them around for > > > compatibility. But I could be mistaken. > > >=20 > > > What do people think we should do? > >=20 > > Yes I agree with the second alternative as well. >=20 > Okay, will you send a patch for it? >=20 I tried to apply the original patch but it failed. Can you send an updated patch set? I've also included the pypump-0.7 patch that I wrote. I have no real way to test it, but maybe you do. --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --3MwIy2ne0vdjdPXF Content-Type: text/plain; charset=utf-8 Content-Disposition: attachment; filename="0002-gnu-Add-python-pypump.patch" Content-Transfer-Encoding: quoted-printable =46rom 584228d422f8b3ddfda6f04486e1360d7b4820aa Mon Sep 17 00:00:00 2001 =46rom: Efraim Flashner Date: Sun, 24 Jul 2016 18:00:25 +0300 Subject: [PATCH 2/2] gnu: Add python-pypump. * gnu/packages/pumpio.scm (python-pypump): New variable. --- gnu/packages/pumpio.scm | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/gnu/packages/pumpio.scm b/gnu/packages/pumpio.scm index a74d474..f834884 100644 --- a/gnu/packages/pumpio.scm +++ b/gnu/packages/pumpio.scm @@ -23,7 +23,9 @@ #:use-module (guix download) #:use-module (guix git-download) #:use-module (guix build-system gnu) + #:use-module (guix build-system python) #:use-module (gnu packages aspell) + #:use-module (gnu packages python) #:use-module (gnu packages qt) #:use-module (gnu packages web)) =20 @@ -66,3 +68,40 @@ (description "Pumpa is a simple pump.io client written in C++ and Qt.") (home-page "https://pumpa.branchable.com/") (license gpl3+))) + +(define-public python-pypump + (package + (name "python-pypump") + (version "0.7") + (source + (origin + (method url-fetch) + (uri (pypi-uri "PyPump" version)) + (sha256 + (base32 + "0100b8r76hwh4lbiwb2dji6jccpi4hgi2ns7qdgb3lwfidnya3ha")))) + (build-system python-build-system) + (arguments `(#:tests? #f)) ; FIXME: can't find test directory. + (inputs + `(("python-dateutil-2" ,python-dateutil-2) + ("python-requests" ,python-requests) + ("python-requests-oauthlib" ,python-requests-oauthlib))) + (home-page "https://github.com/xray7224/PyPump") + (synopsis "Python Pump.io library") + (description "Python Pump.io library") + (license gpl3+) + (properties `((python2-variant . ,(delay python2-pypump)))))) + +(define-public python2-pypump + (let ((pypump (package-with-python2 + (strip-python2-variant python-pypump)))) + (package (inherit pypump) + (inputs + `(("python2-ndg-httpsclient" ,python2-ndg-httpsclient) + ("python2-pyasn1" ,python2-pyasn1) + ("python2-pyopenssl" ,python2-pyopenssl) + ,@(package-inputs pypump))) + (native-inputs + `(("python2-mock" ,python2-mock) + ("python2-setuptools" ,python2-setuptools) + ,@(package-native-inputs pypump)))))) --=20 2.10.0 --3MwIy2ne0vdjdPXF-- --tsOsTdHNUZQcU9Ye Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCgAGBQJXzTj8AAoJEPTB05F+rO6TDKgP/RsrOkYQiJEm8B4skYlZHNfc 4QJk1na68BldxSWi9y3zjBi9V442agj4rrky5EaB/NBtR0/klkf/orYhND3kYrcd y9xAot4scdPN9RO5p+MtSe/W1IYOOyI49ePPr2Uxceztk+44KKG0GGmNOmsPhj6E bc5tVc85+Ih1GV33dgLi/Cmd1d5xR4/HN4uiEypS1NKAr/OWTAkGEduSwfGdZPHa 7FgOLQzell+aaB2wL60N+bOGUA5WHeLVb4yc99erqoco9mj/Cy4ZvddbpDmlImfR riwRbcQOspvgkROYSYIYsFR1XbNgVRdTD1hhFUVaCqZrfv2aCU5haKIZLvlbadG/ c0lKhCnTZSNzHUSoFvG3GMQhs/2vrrha5yiyMngNzh3+DK6vkrsK2XKE/bvOKwFG dztXCpqLAvAVjP25lP9sfAOHWwWoTNH9jiBneJq8QrVJbjlPn7X0HbgQraH2aEXQ fu18u3wwtEgR8h6PW4soVlKuPJFAZs9pBzBQkBXUfyZ1bimm6O0XVNL4tzsDuF4D zWgtmzO/1VvdwLDPMQLyLw1+yRy+qgjNa1SiKAOxX3BeQ/JJWnFKrt2iBdlQa+WV lK1+s10cMDKD9eFX0PFvBPwIFezZmCfywrQeG/puoU9XwoNoBXCyPDJkQloJkpUq 9eKsEV5aXyb0xhNgwAoh =eF11 -----END PGP SIGNATURE----- --tsOsTdHNUZQcU9Ye--