From: Efraim Flashner <efraim@flashner.co.il>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add python-pypump
Date: Mon, 5 Sep 2016 12:21:04 +0300 [thread overview]
Message-ID: <20160905092104.GA23794@macbook42.flashner.co.il> (raw)
In-Reply-To: <20160819221747.cpiu4g2l24qjmwtx@jasmine>
[-- Attachment #1.1: Type: text/plain, Size: 1691 bytes --]
On Fri, Aug 19, 2016 at 06:17:47PM -0400, Leo Famulari wrote:
> On Mon, Aug 15, 2016 at 03:17:57PM -0700, Dylan Jeffers wrote:
> > On Mon, 15 Aug 2016 14:41:28 -0400
> > Leo Famulari <leo@famulari.name> wrote:
> >
> > > On Sun, Aug 14, 2016 at 04:07:11PM -0700, Dylan Jeffers wrote:
> > > > > The latest upstream version 0.7. Is there a reason not to use the
> > > > > latest version in this case?
> > > >
> > > > For my immediate purposes, I need pypump 0.6, since thats the
> > > > version used in my projects. Since the versions are quite
> > > > different, maybe we include both of them?
> > >
> > > I think we should package the latest version, at least.
> > >
> > > Maybe we could also package 0.6 with a package 'python-pypump-0.6'
> > > that inherits from python-pypump. Or, you could keep that inherited
> > > python-pypump-0.6 in a private package repo, and use
> > > GUIX_PACKAGE_PATH.
> > >
> > > I'd prefer the latter option. I don't think we have a precedent of
> > > adding old releases, although we do sometimes keep them around for
> > > compatibility. But I could be mistaken.
> > >
> > > What do people think we should do?
> >
> > Yes I agree with the second alternative as well.
>
> Okay, will you send a patch for it?
>
I tried to apply the original patch but it failed. Can you send an
updated patch set? I've also included the pypump-0.7 patch that I wrote.
I have no real way to test it, but maybe you do.
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[-- Attachment #1.2: 0002-gnu-Add-python-pypump.patch --]
[-- Type: text/plain, Size: 2428 bytes --]
From 584228d422f8b3ddfda6f04486e1360d7b4820aa Mon Sep 17 00:00:00 2001
From: Efraim Flashner <efraim@flashner.co.il>
Date: Sun, 24 Jul 2016 18:00:25 +0300
Subject: [PATCH 2/2] gnu: Add python-pypump.
* gnu/packages/pumpio.scm (python-pypump): New variable.
---
gnu/packages/pumpio.scm | 39 +++++++++++++++++++++++++++++++++++++++
1 file changed, 39 insertions(+)
diff --git a/gnu/packages/pumpio.scm b/gnu/packages/pumpio.scm
index a74d474..f834884 100644
--- a/gnu/packages/pumpio.scm
+++ b/gnu/packages/pumpio.scm
@@ -23,7 +23,9 @@
#:use-module (guix download)
#:use-module (guix git-download)
#:use-module (guix build-system gnu)
+ #:use-module (guix build-system python)
#:use-module (gnu packages aspell)
+ #:use-module (gnu packages python)
#:use-module (gnu packages qt)
#:use-module (gnu packages web))
@@ -66,3 +68,40 @@
(description "Pumpa is a simple pump.io client written in C++ and Qt.")
(home-page "https://pumpa.branchable.com/")
(license gpl3+)))
+
+(define-public python-pypump
+ (package
+ (name "python-pypump")
+ (version "0.7")
+ (source
+ (origin
+ (method url-fetch)
+ (uri (pypi-uri "PyPump" version))
+ (sha256
+ (base32
+ "0100b8r76hwh4lbiwb2dji6jccpi4hgi2ns7qdgb3lwfidnya3ha"))))
+ (build-system python-build-system)
+ (arguments `(#:tests? #f)) ; FIXME: can't find test directory.
+ (inputs
+ `(("python-dateutil-2" ,python-dateutil-2)
+ ("python-requests" ,python-requests)
+ ("python-requests-oauthlib" ,python-requests-oauthlib)))
+ (home-page "https://github.com/xray7224/PyPump")
+ (synopsis "Python Pump.io library")
+ (description "Python Pump.io library")
+ (license gpl3+)
+ (properties `((python2-variant . ,(delay python2-pypump))))))
+
+(define-public python2-pypump
+ (let ((pypump (package-with-python2
+ (strip-python2-variant python-pypump))))
+ (package (inherit pypump)
+ (inputs
+ `(("python2-ndg-httpsclient" ,python2-ndg-httpsclient)
+ ("python2-pyasn1" ,python2-pyasn1)
+ ("python2-pyopenssl" ,python2-pyopenssl)
+ ,@(package-inputs pypump)))
+ (native-inputs
+ `(("python2-mock" ,python2-mock)
+ ("python2-setuptools" ,python2-setuptools)
+ ,@(package-native-inputs pypump))))))
--
2.10.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-09-05 9:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-13 1:31 [PATCH] gnu: Add python-pypump Dylan Jeffers
2016-08-13 12:57 ` Leo Famulari
2016-08-13 19:32 ` Dylan Jeffers
2016-08-13 23:07 ` Leo Famulari
2016-08-14 23:07 ` Dylan Jeffers
2016-08-15 18:41 ` Leo Famulari
2016-08-15 22:17 ` Dylan Jeffers
2016-08-19 22:17 ` Leo Famulari
2016-09-05 9:21 ` Efraim Flashner [this message]
2016-08-15 22:29 ` Danny Milosavljevic
2016-08-15 22:41 ` Leo Famulari
2016-08-16 18:02 ` Leo Famulari
-- strict thread matches above, loose matches on Subject: below --
2017-01-09 10:03 [PATCH 0/9] Add more qtmodules Efraim Flashner
2017-01-09 10:03 ` [PATCH] gnu: Add python-pypump Efraim Flashner
2017-01-09 11:03 ` Efraim Flashner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160905092104.GA23794@macbook42.flashner.co.il \
--to=efraim@flashner.co.il \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).