From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: Re: [PATCH v6 1/2] gnu: Add arduino-libraries.
Date: Wed, 31 Aug 2016 22:40:37 +0200
Message-ID: <20160831224037.15db17bf@scratchpost.org>
References: <20160830190155.11668-1-dannym@scratchpost.org>
	<20160830190155.11668-2-dannym@scratchpost.org>
	<871t14bt16.fsf@elephly.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47834)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1bfCJR-0003lr-L6
	for guix-devel@gnu.org; Wed, 31 Aug 2016 16:40:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1bfCJN-0000b4-Fl
	for guix-devel@gnu.org; Wed, 31 Aug 2016 16:40:44 -0400
Received: from dd1012.kasserver.com ([85.13.128.8]:33687)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1bfCJN-0000aX-6H
	for guix-devel@gnu.org; Wed, 31 Aug 2016 16:40:41 -0400
In-Reply-To: <871t14bt16.fsf@elephly.net>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org

> As this is only used by =E2=80=9Carduino-libraries=E2=80=9D and probably =
no other
> package I=E2=80=99d move this into the definition of =E2=80=9Carduino-lib=
raries=E2=80=9D.

I suppressed arduino-core in this patch series. It will be used by others.

> Could you expand the description a little?  Maybe one more sentence.

What should I write?

Would "There are libraries for Ethernet, GSM, LCD, SD drives, servos, stepp=
er motors, TFT displays and WiFi. " be OK?

> > +    ;;   libraries/Ethernet/src/utility/w5100*: lgpl2.1 =20
>=20
> Only 2.1?  Or is a later version okay?

Only 2.1.

> > diff --git a/gnu/packages/patches/arduino-libraries-hardware-remove-__c=
xa_guard_acquire.patch b/gnu/packages/patches/arduino-libraries-hardware-re=
move-__cxa_guard_acquire.patch =20
>=20
> Please add a comment at the very top of this patch to explain what its
> purpose is.

"Removes function-static variable. Our avr-gcc chokes on it otherwise." ?