From: Danny Milosavljevic <dannym@scratchpost.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH v6 1/2] gnu: Add arduino-libraries.
Date: Wed, 31 Aug 2016 22:40:37 +0200 [thread overview]
Message-ID: <20160831224037.15db17bf@scratchpost.org> (raw)
In-Reply-To: <871t14bt16.fsf@elephly.net>
> As this is only used by “arduino-libraries” and probably no other
> package I’d move this into the definition of “arduino-libraries”.
I suppressed arduino-core in this patch series. It will be used by others.
> Could you expand the description a little? Maybe one more sentence.
What should I write?
Would "There are libraries for Ethernet, GSM, LCD, SD drives, servos, stepper motors, TFT displays and WiFi. " be OK?
> > + ;; libraries/Ethernet/src/utility/w5100*: lgpl2.1
>
> Only 2.1? Or is a later version okay?
Only 2.1.
> > diff --git a/gnu/packages/patches/arduino-libraries-hardware-remove-__cxa_guard_acquire.patch b/gnu/packages/patches/arduino-libraries-hardware-remove-__cxa_guard_acquire.patch
>
> Please add a comment at the very top of this patch to explain what its
> purpose is.
"Removes function-static variable. Our avr-gcc chokes on it otherwise." ?
next prev parent reply other threads:[~2016-08-31 20:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-30 19:01 [PATCH v6 0/2] gnu: Add Arduino tools Danny Milosavljevic
2016-08-30 19:01 ` [PATCH v6 1/2] gnu: Add arduino-libraries Danny Milosavljevic
2016-08-31 20:08 ` Ricardo Wurmus
2016-08-31 20:40 ` Danny Milosavljevic [this message]
2016-08-30 19:01 ` [PATCH v6 2/2] gnu: Add arduino-makefile Danny Milosavljevic
2016-08-31 20:02 ` Ricardo Wurmus
2016-08-31 20:34 ` Danny Milosavljevic
2016-09-01 14:57 ` Ricardo Wurmus
2016-09-01 18:44 ` Danny Milosavljevic
2016-09-01 18:52 ` Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831224037.15db17bf@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=guix-devel@gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).