From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH] gnu: sqlite: Enable DBSTAT_VTAB.
Date: Wed, 31 Aug 2016 14:52:34 -0400
Message-ID: <20160831185234.GC12396@jasmine>
References: <20160830233431.21109-1-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55066)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bfAd0-0003xy-RF
	for guix-devel@gnu.org; Wed, 31 Aug 2016 14:52:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bfAcu-0004uE-UE
	for guix-devel@gnu.org; Wed, 31 Aug 2016 14:52:49 -0400
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:47446)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1bfAct-0004rf-Ng
	for guix-devel@gnu.org; Wed, 31 Aug 2016 14:52:44 -0400
Content-Disposition: inline
In-Reply-To: <20160830233431.21109-1-david@craven.ch>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

On Wed, Aug 31, 2016 at 01:34:30AM +0200, David Craven wrote:
> * gnu/packages/databases.scm (sqlite)[arguments]: Enable configure-flag
>   -DSQLITE_ENABLE_DBSTAT_VTAB.
> ---
>  gnu/packages/databases.scm | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
> index a04c375..ce51d28 100644
> --- a/gnu/packages/databases.scm
> +++ b/gnu/packages/databases.scm
> @@ -520,10 +520,12 @@ for example from a shell script.")
>     (inputs `(("readline" ,readline)))
>     (arguments
>      `(#:configure-flags
> -      ;; Add -DSQLITE_SECURE_DELETE and -DSQLITE_ENABLE_UNLOCK_NOTIFY to
> -      ;; CFLAGS.  GNU Icecat will refuse to use the system SQLite unless these
> -      ;; options are enabled.
> -      '("CFLAGS=-O2 -DSQLITE_SECURE_DELETE -DSQLITE_ENABLE_UNLOCK_NOTIFY")))
> +      ;; Add -DSQLITE_SECURE_DELETE, -DSQLITE_ENABLE_UNLOCK_NOTIFY and
> +      ;; -DSQLITE_ENABLE_DBSTAT_VTAB to CFLAGS.  GNU Icecat will refuse
> +      ;; to use the system SQLite unless these options are enabled.
> +      (list (string-append "CFLAGS=-O2 -DSQLITE_SECURE_DELETE "
> +                           "-DSQLITE_ENABLE_UNLOCK_NOTIFY "
> +                           "-DSQLITE_ENABLE_DBSTAT_VTAB"))))

When the new Icecat is released, I think we should graft this change
onto the master branch. This is because the new Icecat will fix a bunch
of security bugs.