From: Leo Famulari <leo@famulari.name>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: rofi: Update to 1.2.0.
Date: Wed, 31 Aug 2016 14:47:33 -0400 [thread overview]
Message-ID: <20160831184733.GA12396@jasmine> (raw)
In-Reply-To: <87zintx9u1.fsf@ike.i-did-not-set--mail-host-address--so-tickle-me>
On Wed, Aug 31, 2016 at 04:00:06PM +0100, Marius Bakke wrote:
> Greetings Guix,
>
> I am the maintainer of this package in NixOS and figured I could update
> it here as well, since it was non-trivial.
Thanks!
> The libx11 dependency is dropped in favour of a new xcb-util-xrm module.
> I added the latter to xdisorg since it's not listed on xcb.fd.o proper,
> but followed the convention of the other xcb-util-* libraries.
>
> Disclaimer: untested, apart from building with rounds=2.
Okay!
> Subject: [PATCH 1/2] gnu: Add xcb-util-xrm.
>
> * gnu/packages/xdisorg.scm (xcb-util-xrm): New variable.
This actually bundles m4, even if it doesn't use it. Can you delete that
'm4' directory in an origin snippet? There's an example in the calibre
package definition.
> + (uri (string-append
> + "https://github.com/Airblader/xcb-util-xrm/releases/download"
Also this line a bit too long :)
Otherwise LGTM!
next prev parent reply other threads:[~2016-08-31 18:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 15:00 [PATCH] gnu: rofi: Update to 1.2.0 Marius Bakke
2016-08-31 18:47 ` Leo Famulari [this message]
2016-08-31 19:04 ` Marius Bakke
2016-08-31 19:09 ` Marius Bakke
2016-08-31 19:13 ` Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160831184733.GA12396@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).